Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use productized bits and images #70

Merged
merged 17 commits into from
Sep 8, 2023
Merged

Use productized bits and images #70

merged 17 commits into from
Sep 8, 2023

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Jul 25, 2023 •
edited
Loading

Description

Modifying the OpenShift CI automation in order to use a pull secret for pulling released images from secured registries.
Updating the WildFly/EAP8 images related properties to experiment with EAP 8 Beta images in registry.redhat.io.

Fix #62

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fabiobrz fabiobrz self-assigned this Jul 25, 2023
@fabiobrz
Copy link
Member Author

fabiobrz commented Jul 26, 2023 •
edited
Loading

Pulling released product images from a secured registry works, see https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/Intersmash_intersmash/70/pull-ci-Intersmash-intersmash-main-intersmash-e2e/1684150504336134144 ✔️

Next steps

@fabiobrz fabiobrz force-pushed the testps branch 3 times, most recently from 6f0e2bb to d1c0ff4 Compare August 3, 2023 11:41
@fabiobrz fabiobrz force-pushed the testps branch 2 times, most recently from 8379be0 to 0e88a37 Compare August 25, 2023 23:51
@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz fabiobrz mentioned this pull request Aug 30, 2023
Closed
3 tasks
@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz fabiobrz marked this pull request as ready for review August 30, 2023 12:18
@fabiobrz
Copy link
Member Author

Hi @tommaso-borgato - this is ready to be reviewed, see my summary at: #70 (comment)

TL;DR:

We can remove those two [TEMP] commits that I've used fr verification right before merging.

@tommaso-borgato
Copy link
Collaborator

https://docs.google.com/spreadsheets/d/1fCQ7g_sqNramx-lO0bFv6jbnUwOPxZxhHFhe_FfLuqY/edit?usp=sharing

@fabiobrz
[issue 62] - Adding properties to the POMs configuration so that EAP …
30ba956 
…8 Beta productized bits are used when building the deployments with the wildfly-deployments-build.eap profile.

Also, the property is set when building the deplyments-provider so that it can be exposed and forwarded to OpenShift WildFly/EAP s2i builds.
@fabiobrz
[issue 62] - Adding Red Hat EA Maven repository configuration
9c13787
@fabiobrz
[issue 62] - Remove IntersmashToolsProvisionersProperties, deployment…
8539325 
… related properties should be exposed by the deployments module only
@fabiobrz
[issue 62] - Isolating changes for running CI with producton into a n…
1527e2f 
…ew script
@fabiobrz
[issue 62] - Adding properties to the POMs configuration so that prod…
bc949f2 
…uctized images and cloud deliverables are used when executing the testsuite
@fabiobrz
[issue 62] - Adding testsuite JUnit5 test categories to filter select…
9ab5d20 
…ed tests
@fabiobrz
[issue 62] - Filtering tests that shouldn't be executed when the test…
d04fcfe 
…suite execution profile is ts.prod
@fabiobrz
[issue 62] - Filtering provisioners in ProvisionerCleanupTestCase bas…
58ee726 
…ed on the testsuite execution profile
@fabiobrz
[issue 62] - Setting the Kafka version selectively based on community…
55d3ea5 
…/product test execution profile
@fabiobrz
[issue 62] - Adding a property and related configuration logic for Ac…
f791cf1 
…tiveMQ Broker deplotyment plan init image, which is used by the productized version of the ActiveMQ Broker Operator
@fabiobrz
[issue 62] - Fix tables in docs
157e775
@fabiobrz
[TEMP] - CI checks jobs: verify execution against COMMUNITY bits and …
ef21bf9 
…deliverables
@fabiobrz
Copy link
Member Author

fabiobrz commented Sep 7, 2023

The tests that use the prod deliverables will be run periodically once openshift/release#43119 will be merged.

@tommaso-borgato
Copy link
Collaborator

LGTM, merging

@tommaso-borgato tommaso-borgato merged commit 4621526 into Intersmash:main Sep 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommaso-borgato tommaso-borgato tommaso-borgato approved these changes

Assignees

@fabiobrz fabiobrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intersmash should run with products and not just with community projects
2 participants
@fabiobrz @tommaso-borgato