Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WildFly/EAP bits defaults to latest #172

Merged
merged 3 commits into from
May 27, 2024

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented May 9, 2024

Description

See the title. Part of #159

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz
Copy link
Member Author

/retest

1 similar comment
@fabiobrz
Copy link
Member Author

/retest

@fabiobrz fabiobrz force-pushed the bump.wildfly-eap branch 2 times, most recently from 71f382e to 1667d5d Compare May 22, 2024 08:28
@fabiobrz
Copy link
Member Author

/retest

… build only eap7-helloworld-deployment, since buiding the whole project could clash with required Maven 3.6.3, since EAP 7 images use a previous version
intersmash.wildfly.image=quay.io/wildfly/wildfly-s2i-jdk17:latest
intersmash.wildfly.runtime.image=quay.io/wildfly/wildfly-runtime-jdk17:latest
intersmash.wildfly.image=quay.io/wildfly/wildfly-s2i:latest
intersmash.wildfly.runtime.image=quay.io/wildfly/wildfly-runtime:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiobrz that's new for me: no more JDK ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tommaso-borgato. Exactly, this is the new image that should be used, other ones would fail running the s2i build since with the latest plugin, which requires Maven 3.6.3+

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnks @fabiobrz

@tommaso-borgato tommaso-borgato merged commit e9011b4 into Intersmash:main May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants