Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 144] - Support Red Hat Build of Keycloak (new productised version of Keycloak) #155

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Mar 4, 2024

Description

Make the Intersmash provisioning tooling for Keycloak support its latest product counterpart too, i.e. Red Hat Build of keycloak (RHBK)

Fix #144

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz
Copy link
Member Author

/retest

@fabiobrz
Copy link
Member Author

/test intersmash-e2e

@fabiobrz fabiobrz force-pushed the issue-144.suppport-rhbk branch 4 times, most recently from 50b0c69 to 20173be Compare March 29, 2024 10:56
@fabiobrz fabiobrz added the dependencies Pull requests that update a dependency file label Mar 29, 2024
@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 29, 2024

Adding this comment to track the two verification jobs:

before removing the last commit (SHA is 3206f0e of rfuture reference) which is provided by #162 instead.

As the above mentioned jobs are green, the changes are now ready to be reviewed.

Update: rebased after #162 has been merged.

@fabiobrz fabiobrz marked this pull request as draft March 29, 2024 16:06
@fabiobrz fabiobrz marked this pull request as ready for review March 29, 2024 16:19
@marekkopecky marekkopecky merged commit 766ad68 into Intersmash:main Apr 2, 2024
3 checks passed
@marekkopecky
Copy link
Collaborator

LGTM, merging, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants