Workarounds to make constitution executable optionally buildable. #6418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezirg
force-pushed
the
bezirg/fix-constitution-build
branch
from
0493eba to
403dcc4
Compare
bezirg
force-pushed
the
bezirg/fix-constitution-build
branch
from
403dcc4 to
b7e817c
Compare
| @@ -95,6 +95,14 @@ allow-newer: | |||
| , inline-r:containers | |||
| , inline-r:primitive | |||
|
|
|||
| -- Uncomment the following lines to make cardano-constitution:create-json-envelope buildable:True | |||
There was a problem hiding this comment.
This is probably a silly question, but is there no way to tell cabal to only build this if the user turns on some flag?
There was a problem hiding this comment.
Good question, but I don't know how 🤷♂️
| ## Building the script | ||
|
|
||
| We have created an executable `create-json-envelope` to ease the creation of a constitution script. | ||
| This executable is disabled by default; to enable it, uncomment the related lines inside this repo's `cabal.project`: |
There was a problem hiding this comment.
Is there a future plan to move this out of the repo?
v0d1ch
pushed a commit
to v0d1ch/plutus
that referenced
this pull request
Dec 6, 2024
…tersectMBO#6418) Co-authored-by: Nikolaos Bezirgiannis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also I fixed and improved some comments in the constitution package.
Pre-submit checklist: