Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCP 3619: costing for serialiseData #4480

Merged
merged 8 commits into from
Mar 22, 2022
Merged

SCP 3619: costing for serialiseData #4480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4fc2671
Cost function for serialiseData, improved modelling method for fan-sh…
kwxm Mar 18, 2022
8c45a2a
Minor corrections
kwxm Mar 18, 2022
27714a1
Tidying up
kwxm Mar 19, 2022
00c2622
Make info messages clearer
kwxm Mar 19, 2022
124e0ee
Tidying up
kwxm Mar 19, 2022
1ba9bf0
Tidying up
kwxm Mar 19, 2022
a31cf69
Expand comment
kwxm Mar 20, 2022
f05bc83
Typo
kwxm Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plutus-core/cost-model/budgeting-bench/Benchmarks/Data.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ benchEqualsData =
benchSerialiseData :: Benchmark
benchSerialiseData =
createOneTermBuiltinBench SerialiseData [] args
where args = dataSampleForEq -- FIXME: is this a good sample for serialization?
where args = dataSampleForEq
-- FIXME: see if we can find a better sample for this. More generally, how
-- does the internal structure of a Data object influence serialisation
-- time? What causes a Data object to be quick or slow to serialise?

makeBenchmarks :: StdGen -> [Benchmark]
makeBenchmarks gen =
Expand Down
8 changes: 4 additions & 4 deletions plutus-core/cost-model/data/builtinCostModel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@
"equalsData": {
"cpu": {
"arguments": {
"intercept": 1083531,
"slope": 12717
"intercept": 1171539,
"slope": 18595
},
"type": "min_size"
},
Expand Down Expand Up @@ -505,8 +505,8 @@
"serialiseData": {
"cpu": {
"arguments": {
"intercept": 1000,
"slope": 255499
"intercept": 1194288,
"slope": 389135
},
"type": "linear_cost"
},
Expand Down
Loading