Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet-api: Be explicit about block order #346

Merged
merged 1 commit into from
Nov 29, 2018
Merged

wallet-api: Be explicit about block order #346

merged 1 commit into from
Nov 29, 2018

Conversation

j-mueller
Copy link
Contributor

  • Field name indicates the order of blocks in the blockchain

@j-mueller j-mueller requested a review from michaelpj November 29, 2018 09:26
@j-mueller
wallet-api: Be explicit about block order
7017914 
* Field name indicates the order of blocks in the blockchain
@michaelpj
Copy link
Contributor

Possibly in the medium term Blockchain should not be a type alias and these would be operations on the Blockchain, but lgtm for now.

@michaelpj michaelpj merged commit bdfa2cc into master Nov 29, 2018
@j-mueller j-mueller deleted the j-mueller/lenses branch April 9, 2019 16:56
@rmourey26 rmourey26 mentioned this pull request Nov 5, 2022
Open
@rmourey26 rmourey26 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj Awaiting requested review from michaelpj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-mueller @michaelpj