Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest to use Integer instead of Int for Data, Lift and Typeable (fix #3161). #3170

Merged
merged 2 commits into from
May 12, 2021
Merged

Suggest to use Integer instead of Int for Data, Lift and Typeable (fix #3161). #3170

merged 2 commits into from
May 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2021

@effectfully suggested to report an error suggesting to use Integer instead of Int in #3161.

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@ghost ghost requested review from michaelpj, j-mueller and effectfully May 12, 2021 08:22
@michaelpj
Copy link
Contributor

Cute. Can you add one for Lift and Typeable too? They're defined nearby.

effectfully
effectfully approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@effectfully effectfully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost
Copy link
Author

ghost commented May 12, 2021

@michaelpj please take a look at 9a0c24b

@ghost ghost changed the title Suggest to use Integer instead of Int for Data (fix #3161). Suggest to use Integer instead of Int for Data, Lift and Typeable (fix #3161). May 12, 2021
@michaelpj michaelpj merged commit 3131e02 into master May 12, 2021
@ghost ghost deleted the isdata-int-typeerror branch May 12, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mueller j-mueller Awaiting requested review from j-mueller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelpj @effectfully