Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set -Werror in the Nix build only #1915

Merged
merged 3 commits into from
Mar 27, 2020
Merged

Set -Werror in the Nix build only #1915

merged 3 commits into from
Mar 27, 2020

Conversation

michaelpj
Copy link
Contributor

We had this set up before, this gets us back to that position so we keep ourselves warning-clean.

Sadly it's somewhat annoying, see input-output-hk/haskell.nix#519.

@michaelpj
Nicer module syntax
c54fba2
@michaelpj
Set -Werror for everything in CI again
3e566d5 
This proves somewhat annoying, unfortunately. See
input-output-hk/haskell.nix#519 for details.
@michaelpj
Copy link
Contributor Author

@jmchapman plc-agda has some non-exhaustive pattern match warnings. I've turned off -Werror for it, but perhaps you should fix those?

@michaelpj michaelpj merged commit 9e88421 into master Mar 27, 2020
@kwxm kwxm deleted the imp/werror branch November 9, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelpj