Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use-cases: Add TH module for tests #185

Merged
merged 3 commits into from
Oct 11, 2018
Merged

use-cases: Add TH module for tests #185

merged 3 commits into from
Oct 11, 2018

Conversation

j-mueller
Copy link
Contributor

  • Add a Spec.TH module with quoted expressions for creating PendingTx
    values

@j-mueller
use-cases: Add TH module for tests
b767404 
* Add a Spec.TH module with quoted expressions for creating `PendingTx`
  values
effectfully
effectfully approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@effectfully effectfully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I understand what's happening here, but since my review was requested: there are many magic numbers in the code (600, 400, 1600). That's not a big deal, since this is just a test of an example of what can be done with Plutus, but still would be nice to have some explanation.

I certainly like the idea of separating template-haskell expressions from other code.

@j-mueller
Copy link
Contributor Author

Thank you for taking the time to review the PR. I requested a review from you because I thought this would be the quickest way to get it done and it's only a small change. I will add some comments to the numbers.

vmchale
vmchale approved these changes Oct 11, 2018
View reviewed changes
plutus-use-cases/test/Spec/Crowdfunding.hs Outdated Show resolved Hide resolved
@j-mueller j-mueller merged commit 52c8901 into IntersectMBO:master Oct 11, 2018
zeme-iohk pushed a commit that referenced this pull request Jun 9, 2022
[plutus-chain-index]: fix utxo-at-adress beam query (#124). (#185)
b4277aa
zeme-iohk pushed a commit that referenced this pull request Jun 9, 2022
@alegadea
[plutus-chain-index-core]: fix utxo-with-currency beam query. Solutio…
193be4f 
…n related with #185 (#411)

* [plutus-chain-index-code]: fix utxo-with-currency beam query. Solution related with #185.

* [plutus-chain-index-code]: fix utxo-with-currency beam query. Solution related with #185.
@rmourey26 rmourey26 mentioned this pull request Nov 5, 2022
Open
@rmourey26 rmourey26 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmchale vmchale vmchale approved these changes

@effectfully effectfully effectfully approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-mueller @effectfully @vmchale