Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet Names incorrect in Blockchain header #854

Closed
pkellyiohk opened this issue Apr 5, 2019 · 5 comments
Closed

Wallet Names incorrect in Blockchain header #854

pkellyiohk opened this issue Apr 5, 2019 · 5 comments

Comments

@pkellyiohk
Copy link

Instead of Wallet #3 etc.
headers
, there is a hash value showing

@krisajenkins
Copy link
Contributor

This is due to a backend change. We now get ConsumePublicKeyAddress with a PubKey that contains a hash, whereas before it contained the mock wallet ID (1, 2, 3, etc.)

@pkellyiohk
Copy link
Author

OK, so more true-to-life then?

The wallet names in other spots should be changedto match then, right? Add Wallet and Final Balances?

@krisajenkins
Copy link
Contributor

Yeah, it's more realistic. But the trouble is, we don't know what the hash will be at the "Add Wallet" stage, so I think we have to show digit IDs in the other places.

@pkellyiohk
Copy link
Author

OK. Not a bug then. Can be closed or ideally, deferred for improving in next phase post-summit.

@krisajenkins
Copy link
Contributor

Relates to #673.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants