Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Reorganized the dependencies (build-depends) in the cabal files #575

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

koslambrou
Copy link
Contributor

The dependencies in the cabal files are separated in three categories:

  • Local components
  • Other IOG dependencies
  • Non-IOG dependencies

Feel free to propose different categories

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@koslambrou koslambrou force-pushed the kll/reorganize-cabal-build-depends branch from 34d7bcd to de6ba9e Compare July 8, 2022 10:44
@koslambrou koslambrou requested review from a user and michaelpj July 8, 2022 10:50
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

One note. What do you think about using common stanzas to explicitly name them?

common local_packages
  build-depends: plutus-ledger
  ghc-options: -Wall

library
  import: local_packages
  exposed-modules: Foo

@michaelpj
Copy link
Contributor

One note. What do you think about using common stanzas to explicitly name them?

I think this doesn't scale as well when you have multiple components in one cabal file, which we often do.

Copy link
Contributor

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@koslambrou koslambrou force-pushed the kll/reorganize-cabal-build-depends branch from de6ba9e to 696f038 Compare July 8, 2022 12:00
@koslambrou
Copy link
Contributor Author

@ak3n Good point, but I think as well that using common stanzas for that case will make the cabal files inconsistent when there's multiple components in one cabal file.

@koslambrou koslambrou marked this pull request as ready for review July 8, 2022 17:53
@koslambrou koslambrou merged commit 50b7bb5 into main Jul 8, 2022
@koslambrou koslambrou deleted the kll/reorganize-cabal-build-depends branch July 8, 2022 17:53
koslambrou added a commit that referenced this pull request Jul 8, 2022
koslambrou added a commit that referenced this pull request Jul 8, 2022
koslambrou added a commit that referenced this pull request Jul 8, 2022
koslambrou added a commit that referenced this pull request Jul 8, 2022
koslambrou added a commit that referenced this pull request Jul 9, 2022
koslambrou added a commit that referenced this pull request Jul 9, 2022
koslambrou added a commit that referenced this pull request Apr 6, 2023
koslambrou added a commit that referenced this pull request Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants