This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 214
Reorganized the dependencies (build-depends) in the cabal files #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koslambrou
force-pushed
the
kll/reorganize-cabal-build-depends
branch
from
July 8, 2022 10:44
34d7bcd
to
de6ba9e
Compare
ghost
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
One note. What do you think about using common stanzas to explicitly name them?
common local_packages
build-depends: plutus-ledger
ghc-options: -Wall
library
import: local_packages
exposed-modules: Foo
I think this doesn't scale as well when you have multiple components in one cabal file, which we often do. |
michaelpj
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
koslambrou
force-pushed
the
kll/reorganize-cabal-build-depends
branch
from
July 8, 2022 12:00
de6ba9e
to
696f038
Compare
@ak3n Good point, but I think as well that using common stanzas for that case will make the cabal files inconsistent when there's multiple components in one cabal file. |
koslambrou
added a commit
that referenced
this pull request
Jul 8, 2022
koslambrou
added a commit
that referenced
this pull request
Jul 8, 2022
8 tasks
koslambrou
added a commit
that referenced
this pull request
Jul 8, 2022
koslambrou
added a commit
that referenced
this pull request
Jul 8, 2022
koslambrou
added a commit
that referenced
this pull request
Jul 8, 2022
koslambrou
added a commit
that referenced
this pull request
Jul 9, 2022
koslambrou
added a commit
that referenced
this pull request
Apr 6, 2023
koslambrou
added a commit
that referenced
this pull request
Apr 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies in the cabal files are separated in three categories:
Feel free to propose different categories
Pre-submit checklist: