Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

Conversation

koslambrou
Copy link
Contributor

@koslambrou koslambrou commented Jun 27, 2022

Add ownAddresses request in Contract API which will replace ownPaymentPubKeyHash.

  • ownPaymentPubKeyHash is marked as deprecated

  • All plutus-use-cases examples replace usage of ownPaymentPubKeyHash with ownAddresses

  • Fix plutus-pab-local-cluster which wasn't working because the chain-index wasn't in sync with the PAB

Should fix #473

This PR was tested by changing the IntegrationTest contract to use ownAddresses instead of ownPaymentPubKeyHash and running plutus-pab-local-cluster and see the message Tx confirmed log message.

FYI: @etiennejf

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reference the ADR in the PR and reference the PR in the ADR (if revelant)
    • Reviewer requested

@koslambrou koslambrou force-pushed the PLT-313-plutus-contract-replace-own-payment-pub-key-hash-with-own-addresses-in-wallet-effect branch 5 times, most recently from 127fdf9 to f3d656e Compare June 27, 2022 15:52
@koslambrou koslambrou requested review from sjoerdvisscher and a user June 27, 2022 16:49
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

plutus-contract/src/Plutus/Contract/Request.hs Outdated Show resolved Hide resolved
plutus-pab/src/Cardano/Wallet/Mock/API.hs Show resolved Hide resolved
plutus-pab/src/Cardano/Wallet/Mock/Types.hs Show resolved Hide resolved
@koslambrou koslambrou force-pushed the PLT-313-plutus-contract-replace-own-payment-pub-key-hash-with-own-addresses-in-wallet-effect branch 2 times, most recently from 3468a1e to 67404bb Compare June 28, 2022 14:09
plutus-contract/src/Wallet/Effects.hs Outdated Show resolved Hide resolved
@koslambrou koslambrou force-pushed the PLT-313-plutus-contract-replace-own-payment-pub-key-hash-with-own-addresses-in-wallet-effect branch 2 times, most recently from 6e8ea07 to 5c58a01 Compare June 30, 2022 15:42
…wnPaymentPubKeyHash.

* `ownPaymentPubKeyHash` is marked as deprecated

* All plutus-use-cases examples replace usage of `ownPaymentPubKeyHash` with `ownAddresses`

* Fix plutus-pab-local-cluster which wasn't working because the chain-index wasn't in sync with the PAB
@koslambrou koslambrou force-pushed the PLT-313-plutus-contract-replace-own-payment-pub-key-hash-with-own-addresses-in-wallet-effect branch from 5c58a01 to ba868c0 Compare June 30, 2022 16:32
@koslambrou koslambrou merged commit 379d8f9 into main Jun 30, 2022
@koslambrou koslambrou deleted the PLT-313-plutus-contract-replace-own-payment-pub-key-hash-with-own-addresses-in-wallet-effect branch June 30, 2022 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Test Failure in pab-executables
2 participants