This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
ContractModel: Add wiggle room options to NoLockedFunds #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximilianAlgehed
force-pushed
the
PR-NLFP-WiggleRoom
branch
from
6dcc271
to
90f187f
Compare
MaximilianAlgehed
changed the title
MaximilianAlgehed
force-pushed
the
PR-NLFP-WiggleRoom
branch
2 times, most recently
from
82f913d
to
fc52a44
Compare
|
@sjoerdvisscher Do you mind looking at this when you have a gap in your schedule? |
sjoerdvisscher
approved these changes
Feb 15, 2022
plutus-contract/src/Plutus/Contract/Test/ContractModel/Internal.hs
Outdated
Show resolved
Hide resolved
MaximilianAlgehed
force-pushed
the
PR-NLFP-WiggleRoom
branch
from
be70fc5
to
41530b3
Compare
|
Done :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some contracts, like the Uniswap example contract, have predictable overhead and rounding errors that prevent the strict NoLockedFunds property from passing. This PR introduces a little bit of wiggle room to allow for such contracts.
Pre-submit checklist: