fixup Real PBFT setup #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
approved these changes
Aug 13, 2019
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 13, 2019
916: fixup Real PBFT setup r=mrBliss a=nfrisby The `RealPBFT` setup was creating nodes with different `CoreNodeId`s than expected. This was causing property failures during my work-in-progress on Issue #231 PR #773. Is it safe to export `plcCoreNodeId`, even just for testing? I'm weary of adding exports to code I'm not familiar with. Co-authored-by: Nicolas Frisby <[email protected]>
Timed out |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 13, 2019
916: fixup Real PBFT setup r=mrBliss a=nfrisby The `RealPBFT` setup was creating nodes with different `CoreNodeId`s than expected. This was causing property failures during my work-in-progress on Issue #231 PR #773. Is it safe to export `plcCoreNodeId`, even just for testing? I'm weary of adding exports to code I'm not familiar with. Co-authored-by: Nicolas Frisby <[email protected]>
Timed out |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 13, 2019
914: Replace the ThreadRegistry with the ResourceRegistry r=mrBliss a=mrBliss
Threads (and sub-`ThreadRegistry`s) are also resources, so we can use the `ResourceRegistry` to allocate/release them, instead of having two separate `-Registry`s.
TODO: consensus tests are failing with:
```
Exception:
ResourceRegistry used after closing
CallStack (from HasCallStack):
error, called at src/Ouroboros/Consensus/Util/ResourceRegistry.hs:104:31 in ouroboros-consensus-0.1.0.0-6HDMr0z0KdXIwfzJlxCxiL:Ouroboros.Consensus.Util.ResourceRegistry
```
916: fixup Real PBFT setup r=mrBliss a=nfrisby
The `RealPBFT` setup was creating nodes with different `CoreNodeId`s than expected. This was causing property failures during my work-in-progress on Issue #231 PR #773.
Is it safe to export `plcCoreNodeId`, even just for testing? I'm weary of adding exports to code I'm not familiar with.
918: Eq and Ord instances for Async m a r=dcoutts a=coot
Using 'QuantifiedConstraints' extension in 'MonadAsync'.
Also provide instances for 'Async (SimM s) a'.
Co-authored-by: Thomas Winant <[email protected]>
Co-authored-by: Edsko de Vries <[email protected]>
Co-authored-by: Nicolas Frisby <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
Sep 13, 2019
1002: Use fewer test cases when testing the RealPBFT setup r=nfrisby a=nfrisby PR #916 added a simple property that merely tests the setup for the genuine `RealPBFT` test. This PR fixes its number of tests at 10, since the test is somewhat minor, and it seems disproportionately slow: taking about ~1min to run on my machine. Co-authored-by: Nicolas Frisby <[email protected]>
coot
added a commit
that referenced
this pull request
May 16, 2022
914: Replace the ThreadRegistry with the ResourceRegistry r=mrBliss a=mrBliss
Threads (and sub-`ThreadRegistry`s) are also resources, so we can use the `ResourceRegistry` to allocate/release them, instead of having two separate `-Registry`s.
TODO: consensus tests are failing with:
```
Exception:
ResourceRegistry used after closing
CallStack (from HasCallStack):
error, called at src/Ouroboros/Consensus/Util/ResourceRegistry.hs:104:31 in ouroboros-consensus-0.1.0.0-6HDMr0z0KdXIwfzJlxCxiL:Ouroboros.Consensus.Util.ResourceRegistry
```
916: fixup Real PBFT setup r=mrBliss a=nfrisby
The `RealPBFT` setup was creating nodes with different `CoreNodeId`s than expected. This was causing property failures during my work-in-progress on Issue #231 PR #773.
Is it safe to export `plcCoreNodeId`, even just for testing? I'm weary of adding exports to code I'm not familiar with.
918: Eq and Ord instances for Async m a r=dcoutts a=coot
Using 'QuantifiedConstraints' extension in 'MonadAsync'.
Also provide instances for 'Async (SimM s) a'.
Co-authored-by: Thomas Winant <[email protected]>
Co-authored-by: Edsko de Vries <[email protected]>
Co-authored-by: Nicolas Frisby <[email protected]>
Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RealPBFTsetup was creating nodes with differentCoreNodeIds than expected. This was causing property failures during my work-in-progress on Issue #231 PR #773.Is it safe to export
plcCoreNodeId, even just for testing? I'm weary of adding exports to code I'm not familiar with.