Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cancelWith to the MonadAsync type class #912

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Aug 10, 2019

No description provided.

Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The only reason we left this out initially was that we didn't have full async exceptions support. But we do now.

@dcoutts
Copy link
Contributor

dcoutts commented Aug 11, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 11, 2019
912: Added cancelWith to the MonadAsync type class r=dcoutts a=coot



Co-authored-by: Marcin Szamotulski <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 11, 2019

@iohk-bors iohk-bors bot merged commit 1fe65f6 into master Aug 11, 2019
@iohk-bors iohk-bors bot deleted the coot/cancelWith branch August 11, 2019 21:22
iohk-bors bot added a commit that referenced this pull request Aug 21, 2019
913: Subscription worker - state mangment r=coot a=coot

This is redesign of subscription worker to add state (abstract in this PR).  It is done in the style of `Server.Socket`.

It relies on PR #912 .

Co-authored-by: Marcin Szamotulski <[email protected]>
coot added a commit that referenced this pull request May 16, 2022
912: Added cancelWith to the MonadAsync type class r=dcoutts a=coot



Co-authored-by: Marcin Szamotulski <[email protected]>
coot added a commit that referenced this pull request May 16, 2022
913: Subscription worker - state mangment r=coot a=coot

This is redesign of subscription worker to add state (abstract in this PR).  It is done in the style of `Server.Socket`.

It relies on PR #912 .

Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants