Chain DB: catch and rewrap iterator exceptions #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ImmutableDB and the VolatileDB use an `ErrorHandling` record to throw and catch exceptions (~= a dictionary for `MonadCatch` that can also be instantiated using `ExceptT`, etc.). In `withDB`, which catches ImmutableDB/VolatileDB exceptions, we were just using `MonadCatch` instead of `ErrorHandling.catchError`, so that we were not actually catching the errors (nor rethrowing them wrapped in `ChainDbFailure`). Fix this by storing the `ErrorHandling` that was passed to open the respective DB and use it in `withDB` to properly catch the exceptions.
We use the `ImmDB.withDB` wrapper for functions on the ImmutableDB so that errors are properly caught and rethrown. This was not being used for functions using ImmutableDB iterators, so that errors thrown by these were not being handled properly. Fix this by exposing wrapped version of these functions. This means these functions now take an `ImmDB` as extra argument.
mrBliss
added
bug
mrBliss
added a commit
that referenced
this pull request
Jul 26, 2019
PR #797 was recently merged, which no longer compiled after merging with master because of PR #810. CI did not signal this because there were no merge conflicts and it never rebuilt PR #797 against the updated master. To avoid this in the future, use `bors r+`, which first tries to build the merged PR (as opposed to the unmerged PR branch) before actually pushing to master.
Merged
iohk-bors bot
added a commit
that referenced
this pull request
Jul 26, 2019
831: Fix broken master r=nc6 a=mrBliss PR #797 was recently merged, which no longer compiled after merging with master because of PR #810. CI did not signal this because there were no merge conflicts and it never rebuilt PR #797 against the updated master. To avoid this in the future, use `bors r+`, which first tries to build the merged PR (as opposed to the unmerged PR branch) before actually pushing to master. Co-authored-by: Thomas Winant <[email protected]>
coot
pushed a commit
that referenced
this pull request
May 16, 2022
…ndling Chain DB: catch and rewrap iterator exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly catch exceptions encountered by ImmutableDB iterators (used by ChainDB iterators and readers) and rewrap them in
ChainDbFailure.