Update references to cardano-ledger #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
force-pushed
the
intricate/update-cardano-ledger
branch
from
602c637 to
662a4a3
Compare
intricate
commented
Jun 24, 2019
| @@ -418,10 +421,13 @@ applyByronGenTx :: Bool -- ^ Have we verified this transaction previously? | |||
| applyByronGenTx _reapply (ByronLedgerConfig cfg) genTx st@ByronLedgerState{..} = | |||
| (\x -> st { blsCurrent = x }) <$> go genTx blsCurrent | |||
| where | |||
| validationMode = fromBlockValidationMode CC.Block.BlockValidation | |||
There was a problem hiding this comment.
For now, I'm just hardcoding the BlockValidationMode as BlockValidation but I will utilize the reapply flag in the PR for #440.
Something like fromBlockValidationMode (if reapply then CC.Block.BlockValidation else CC.Block.NoBlockValidation).
mrBliss
approved these changes
Jun 24, 2019
|
I think both @nc6 and @avieth (?) are absent this week and I don't want this to block @intricate, so merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now referencing
cardano-ledger@e2d4663f2251ef76bae94e48fef910b8f5f867bdPrerequisite for issues #440 and #592.