Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped NodeToClient versions < 16 #5002

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Dropped NodeToClient versions < 16 #5002

merged 2 commits into from
Oct 28, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Oct 28, 2024 •
edited
Loading

Description

  • ouroboros-network-api: droped all versions < NodeToClientV_16
  • Updated `check-changelogs.sh script

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot coot requested review from a team as code owners October 28, 2024 11:57
@coot coot added the node-to-client Issues & PRs related to node-to-client protocols label Oct 28, 2024
@coot coot force-pushed the coot/drop-node-to-client-versions branch from 9642a64 to ad30d29 Compare October 28, 2024 11:59
@coot coot self-assigned this Oct 28, 2024
@coot coot linked an issue Oct 28, 2024 that may be closed by this pull request
Remove vestigial NodeTo*Version constructors #3129
Closed
@coot coot requested a review from amesgen October 28, 2024 12:01
@coot coot force-pushed the coot/drop-node-to-client-versions branch from ad30d29 to 7d87052 Compare October 28, 2024 12:07
bolt12
bolt12 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coot coot force-pushed the coot/drop-node-to-client-versions branch from 7d87052 to 99dab2a Compare October 28, 2024 12:12
amesgen
amesgen approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will allow us to remove quite some cruft in Consensus ❤️

@amesgen
Copy link
Member

amesgen commented Oct 28, 2024

Maybe doesn't have to happen in this PR, but https://github.com/IntersectMBO/ouroboros-network/blob/main/cardano-ping/src/Cardano/Network/Ping.hs still has the old versions; maybe it makes sense to keep them there for some time for e.g. debugging.

@coot
Copy link
Contributor Author

coot commented Oct 28, 2024

I don't think we need to support old nodes in cardano-ping.

@coot coot force-pushed the coot/drop-node-to-client-versions branch from 3319f5d to 99dab2a Compare October 28, 2024 19:16
@coot
Copy link
Contributor Author

coot commented Oct 28, 2024

Karl opposed removing versions from cardano-ping, so let's keep them.

@coot coot enabled auto-merge October 28, 2024 19:19
@coot coot added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 18b4a3e Oct 28, 2024
17 checks passed
@coot coot deleted the coot/drop-node-to-client-versions branch October 28, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

@amesgen amesgen amesgen approved these changes

Assignees

@coot coot

Labels
node-to-client Issues & PRs related to node-to-client protocols
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove vestigial NodeTo*Version constructors
3 participants
@coot @amesgen @bolt12