New project `ouroboros-consensus-cardano-tools` #3817

mgmeier · 2022-06-20T13:16:58Z

A new project ouroboros-consensus-cardano-tools is added to the consensus repository. It contains two tools, db-synthesizer and db-analyser. The former is a new implementation, the latter is a refactoring of the analyser tool from the project ouroboros-consensus-cardano.

db-synthesizer synthetically creates a valid ChainDB on-disk; the blocks created do not contain any transactions
The synthesizer utilizes code ported from the node repository to instantiate SomeConsensusProtocol and credentials for block forging
db-analyser is refactored to offer an API for use as a library or as part of a test suite
Both tools' executables share a common library
The original analyser remains in place in this PR, so the new executable is currently named db-analyser2

A test is provided for the new project where both tools are mutually validated.

deepfire · 2022-07-07T23:25:58Z

ouroboros-consensus-cardano-tools/ouroboros-consensus-cardano-tools.cabal

+  if flag(asserts)
+    ghc-options:       -fno-ignore-asserts
+
+executable db-analyser2


I guess we need to negotiate the situation with consensus folks here.

Let's ask them if they agree to drop their analyser and take our modularised version of it.

If they agree -- the drop-and-replacement should be a part of this PR, I'd assume.

cc @nfrisby

deepfire · 2022-07-07T23:27:25Z

ouroboros-consensus-cardano-tools/ouroboros-consensus-cardano-tools.cabal

+  other-modules:       Cardano.Api.Key
+                     , Cardano.Api.KeysByron
+                     , Cardano.Api.KeysPraos
+                     , Cardano.Api.KeysShelley
+                     , Cardano.Api.OperationalCertificate
+                     , Cardano.Api.SerialiseUsing
+                     , Cardano.Api.SerialiseTextEnvelope
+                     , Cardano.Node.Protocol.Alonzo
+                     , Cardano.Node.Protocol.Byron
+                     , Cardano.Node.Protocol.Cardano
+                     , Cardano.Node.Protocol.Shelley


That's another question of negotiation, I guess.

I reckon that @nfrisby has already implemented the "node config"-based configuration for the analyser -- so maybe we need to join efforts there.

On the other hand, there would be no such luxury for the credentials handling -- this is 100% new..

The "node-config" based analyser code is already present in this PR. @nfrisby thankfully notified me when he merged the corresponding feature branch into master, so I could port the relevant changes.

A follow-up consideration is part of the draft issue cardano-tools: code deduplication & future maintenance in https://github.com/orgs/input-output-hk/projects/22/views/1: using "node-config" in the analyser has opened up room for removing redundant code for both tools.

The decision would be, since that does not change behaviour or API at all, if we want that to be in scope for this PR, or whether it's better suited for a future next step.

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBSynthesizer/Forging.hs

ouroboros-consensus/src/Ouroboros/Consensus/NodeKernel.hs

dnadales

Thanks for this PR!

It looks good to me. Here are some things we should address:

Decide wether it'd make sense to drop the old db analyser.
Sort import groups according to the consensus style guide.
Update the changelog.

ouroboros-consensus-cardano-tools/Documentation.md

ouroboros-consensus-cardano-tools/app/DBAnalyser/Parsers.hs

ouroboros-consensus-cardano-tools/app/db-analyser.hs

ouroboros-consensus-cardano-tools/app/db-synthesizer.hs

ouroboros-consensus-cardano-tools/ouroboros-consensus-cardano-tools.cabal

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBSynthesizer/Run.hs

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBSynthesizer/Types.hs

ouroboros-consensus-cardano-tools/test/Main.hs

mgmeier · 2022-08-03T15:11:33Z

@dnadales Thank you for your detailed feedback. I've:

rebased this branch on current master
removed db-analyser from its original location
adressed all styling and implementation related feedback
commented on design related feedback
added documentation

I will remove the draft status of this PR now. Please confirm it's ready for merge, and do mention if any more points should come to mind. Thanks!

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBAnalyser/Block/Byron.hs

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBAnalyser/Block/Cardano.hs

dnadales

Looks good. Thanks!

Only a minor question: should db-synthesizer be mentioned in the consensus changelog? https://github.com/input-output-hk/ouroboros-network/blob/1caae114f5085ac9fcaf9ef3ca022ececb622695/ouroboros-consensus/docs/interface-CHANGELOG.md

Signed-off-by: Michael Karg <[email protected]>

mgmeier · 2022-08-09T15:16:16Z

bors r+

iohk-bors · 2022-08-09T16:25:15Z

Build succeeded:

4025: build(deps): bump haskell/actions from 1 to 2 r=amesgen a=dependabot[bot] Bumps [haskell/actions](https://github.com/haskell/actions) from 1 to 2. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/haskell/actions/commit/73704b4d0366d120a1d694b2fbb3f4708806c9d0"><code>73704b4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/haskell/actions/issues/113">#113</a> from andreasabel/ghc-9.4</li> <li><a href="https://github.com/haskell/actions/commit/968e175ff94d685b6ce0bb39b02447cca8b4a6bb"><code>968e175</code></a> Add GHC 9.4.1, 9.2.4, 9.2.3, Cabal 3.8.1.0. Bump ghcup.</li> <li><a href="https://github.com/haskell/actions/commit/f7b0997283589ea5a6b4f2ade6a239d70a412877"><code>f7b0997</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/haskell/actions/issues/105">#105</a> from rethab/feat/node-16</li> <li><a href="https://github.com/haskell/actions/commit/b9d18eaf11de66db1ef1be9ae11830120e7810a0"><code>b9d18ea</code></a> update dist</li> <li><a href="https://github.com/haskell/actions/commit/97946cc96afb428be53f61f71432bbe726e47bc1"><code>97946cc</code></a> bye</li> <li><a href="https://github.com/haskell/actions/commit/82a6a7668b762c69c58a3db6b2788a572e6638ef"><code>82a6a76</code></a> pth</li> <li><a href="https://github.com/haskell/actions/commit/bf9b0ac8aade6af0c01007d0822dbdddc9b2d452"><code>bf9b0ac</code></a> paths</li> <li><a href="https://github.com/haskell/actions/commit/d933549cd08fd452f3758037a25ca8a9141cba71"><code>d933549</code></a> hlint-setup</li> <li><a href="https://github.com/haskell/actions/commit/cdd84c6078203a8c77d3cdf05aa9f3eb93b275d7"><code>cdd84c6</code></a> add check</li> <li><a href="https://github.com/haskell/actions/commit/71efc905fce387a05c524d6323c8cae85cf9397e"><code>71efc90</code></a> generate dist/index.js</li> <li>Additional commits viewable in <a href="https://github.com/haskell/actions/compare/v1...v2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=haskell/actions&package-manager=github_actions&previous-version=1&new-version=2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 4026: build(deps): bump actions/checkout from 2 to 3 r=amesgen a=dependabot[bot] Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li>Updated to the node16 runtime by default <ul> <li>This requires a minimum <a href="https://github.com/actions/runner/releases/tag/v2.285.0">Actions Runner</a> version of v2.285.0 to run, which is by default available in GHES 3.4 or later.</li> </ul> </li> </ul> <h2>v2.4.2</h2> <h2>What's Changed</h2> <ul> <li>Add set-safe-directory input to allow customers to take control. (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/770">#770</a>) by <a href="https://github.com/TingluoHuang"><code>`@TingluoHuang</code></a>` in <a href="https://github-redirect.dependabot.com/actions/checkout/pull/776">actions/checkout#776</a></li> <li>Prepare changelog for v2.4.2. by <a href="https://github.com/TingluoHuang"><code>`@TingluoHuang</code></a>` in <a href="https://github-redirect.dependabot.com/actions/checkout/pull/778">actions/checkout#778</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v2...v2.4.2">https://github.com/actions/checkout/compare/v2...v2.4.2</a></p> <h2>v2.4.1</h2> <ul> <li>Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></li> </ul> <h2>v2.4.0</h2> <ul> <li>Convert SSH URLs like <code>org-<ORG_ID>`@github.com:</code>` to <code>https://github.com/</code> - <a href="https://github-redirect.dependabot.com/actions/checkout/pull/621">pr</a></li> </ul> <h2>v2.3.5</h2> <p>Update dependencies</p> <h2>v2.3.4</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/379">Add missing <code>await</code>s</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/360">Swap to Environment Files</a></li> </ul> <h2>v2.3.3</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/345">Remove Unneeded commit information from build logs</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/326">Add Licensed to verify third party dependencies</a></li> </ul> <h2>v2.3.2</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/320">Add Third Party License Information to Dist Files</a></p> <h2>v2.3.1</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></p> <h2>v2.3.0</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/278">Fallback to the default branch</a></p> <h2>v2.2.0</h2> <p><a href="https://github-redirect.dependabot.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></p> <h2>v2.1.1</h2> <p>Changes to support GHES (<a href="https://github-redirect.dependabot.com/actions/checkout/pull/236">here</a> and <a href="https://github-redirect.dependabot.com/actions/checkout/pull/248">here</a>)</p> <h2>v2.1.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/191">Group output</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/199">Changes to support GHES alpha release</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/184">Persist core.sshCommand for submodules</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/163">Add support ssh</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/179">Convert submodule SSH URL to HTTPS, when not using SSH</a></li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md">actions/checkout's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h2>v3.0.2</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/770">Add input <code>set-safe-directory</code></a></li> </ul> <h2>v3.0.1</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/762">Fixed an issue where checkout failed to run in container jobs due to the new git setting <code>safe.directory</code></a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/744">Bumped various npm package versions</a></li> </ul> <h2>v3.0.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/689">Update to node 16</a></li> </ul> <h2>v2.3.1</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/284">Fix default branch resolution for .wiki and when using SSH</a></li> </ul> <h2>v2.3.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/278">Fallback to the default branch</a></li> </ul> <h2>v2.2.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/258">Fetch all history for all tags and branches when fetch-depth=0</a></li> </ul> <h2>v2.1.1</h2> <ul> <li>Changes to support GHES (<a href="https://github-redirect.dependabot.com/actions/checkout/pull/236">here</a> and <a href="https://github-redirect.dependabot.com/actions/checkout/pull/248">here</a>)</li> </ul> <h2>v2.1.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/191">Group output</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/199">Changes to support GHES alpha release</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/184">Persist core.sshCommand for submodules</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/163">Add support ssh</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/179">Convert submodule SSH URL to HTTPS, when not using SSH</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/157">Add submodule support</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/144">Follow proxy settings</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/141">Fix ref for pr closed event when a pr is merged</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/128">Fix issue checking detached when git less than 2.22</a></li> </ul> <h2>v2.0.0</h2> <ul> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/108">Do not pass cred on command line</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/107">Add input persist-credentials</a></li> <li><a href="https://github-redirect.dependabot.com/actions/checkout/pull/104">Fallback to REST API to download repo</a></li> </ul> <h2>v2 (beta)</h2> <ul> <li>Improved fetch performance</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/checkout/commit/2541b1294d2704b0964813337f33b291d3f8596b"><code>2541b12</code></a> Prepare changelog for v3.0.2. (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/777">#777</a>)</li> <li><a href="https://github.com/actions/checkout/commit/0ffe6f9c5599e73776da5b7f113e994bc0a76ede"><code>0ffe6f9</code></a> Add set-safe-directory input to allow customers to take control. (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/770">#770</a>)</li> <li><a href="https://github.com/actions/checkout/commit/dcd71f646680f2efd8db4afa5ad64fdcba30e748"><code>dcd71f6</code></a> Enforce safe directory (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/762">#762</a>)</li> <li><a href="https://github.com/actions/checkout/commit/add3486cc3b55d4a5e11c8045058cef96538edc7"><code>add3486</code></a> Patch to fix the dependbot alert. (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/744">#744</a>)</li> <li><a href="https://github.com/actions/checkout/commit/5126516654c75f76bca1de45dd82a3006d8890f9"><code>5126516</code></a> Bump minimist from 1.2.5 to 1.2.6 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/741">#741</a>)</li> <li><a href="https://github.com/actions/checkout/commit/d50f8ea76748df49594d9b109b614f3b4db63c71"><code>d50f8ea</code></a> Add v3.0 release information to changelog (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/740">#740</a>)</li> <li><a href="https://github.com/actions/checkout/commit/2d1c1198e79c30cca5c3957b1e3b65ce95b5356e"><code>2d1c119</code></a> update test workflows to checkout v3 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/709">#709</a>)</li> <li><a href="https://github.com/actions/checkout/commit/a12a3943b4bdde767164f792f33f40b04645d846"><code>a12a394</code></a> update readme for v3 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/708">#708</a>)</li> <li><a href="https://github.com/actions/checkout/commit/8f9e05e482293f862823fcca12d9eddfb3723131"><code>8f9e05e</code></a> Update to node 16 (<a href="https://github-redirect.dependabot.com/actions/checkout/issues/689">#689</a>)</li> <li>See full diff in <a href="https://github.com/actions/checkout/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 4027: build(deps): bump actions/cache from 2 to 3 r=amesgen a=dependabot[bot] Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/releases">actions/cache's releases</a>.</em></p> <blockquote> <h2>v3.0.0</h2> <ul> <li> <p>This change adds a minimum runner version(node12 -> node16), which can break users using an out-of-date/fork of the runner. This would be most commonly affecting users on GHES 3.3 or before, as those runners do not support node16 actions and they can use actions from github.com via <a href="https://docs.github.com/en/[email protected]/admin/github-actions/managing-access-to-actions-from-githubcom/enabling-automatic-access-to-githubcom-actions-using-github-connect">github connect</a> or manually copying the repo to their GHES instance.</p> </li> <li> <p>Few dependencies and cache action usage examples have also been updated.</p> </li> </ul> <h2>v2.1.7</h2> <p>Support 10GB cache upload using the latest version <code>1.0.8</code> of <a href="https://www.npmjs.com/package/`@actions/cache"><code>@actions/cache</code>` </a></p> <h2>v2.1.6</h2> <ul> <li>Catch unhandled "bad file descriptor" errors that sometimes occurs when the cache server returns non-successful response (<a href="https://github-redirect.dependabot.com/actions/cache/pull/596">actions/cache#596</a>)</li> </ul> <h2>v2.1.5</h2> <ul> <li>Fix permissions error seen when extracting caches with GNU tar that were previously created using BSD tar (<a href="https://github-redirect.dependabot.com/actions/cache/issues/527">actions/cache#527</a>)</li> </ul> <h2>v2.1.4</h2> <ul> <li>Make caching more verbose <a href="https://github-redirect.dependabot.com/actions/toolkit/pull/650">#650</a></li> <li>Use GNU tar on macOS if available <a href="https://github-redirect.dependabot.com/actions/toolkit/pull/701">#701</a></li> </ul> <h2>v2.1.3</h2> <ul> <li>Upgrades <code>`@actions/core</code>` to v1.2.6 for <a href="https://github.com/advisories/GHSA-mfwh-5m23-j46w">CVE-2020-15228</a>. This action was not using the affected methods.</li> <li>Fix error handling in <code>uploadChunk</code> where 400-level errors were not being detected and handled correctly</li> </ul> <h2>v2.1.2</h2> <ul> <li>Adds input to limit the chunk upload size, useful for self-hosted runners with slower upload speeds</li> <li>No-op when executing on GHES</li> </ul> <h2>v2.1.1</h2> <ul> <li>Update <code>`@actions/cache</code>` package to <code>v1.0.2</code> which allows cache action to use posix format when taring files.</li> </ul> <h2>v2.1.0</h2> <ul> <li>Replaces the <code>http-client</code> with the Azure Storage SDK for NodeJS when downloading cache content from Azure. This should help improve download performance and reliability as the SDK downloads files in 4 MB chunks, which can be parallelized and retried independently</li> <li>Display download progress and speed</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/cache/blob/main/RELEASES.md">actions/cache's changelog</a>.</em></p> <blockquote> <h1>Releases</h1> <h3>3.0.0</h3> <ul> <li>Updated minimum runner version support from node 12 -> node 16</li> </ul> <h3>3.0.1</h3> <ul> <li>Added support for caching from GHES 3.5.</li> <li>Fixed download issue for files > 2GB during restore.</li> </ul> <h3>3.0.2</h3> <ul> <li>Added support for dynamic cache size cap on GHES.</li> </ul> <h3>3.0.3</h3> <ul> <li>Fixed avoiding empty cache save when no files are available for caching. (<a href="https://github-redirect.dependabot.com/actions/cache/issues/624">issue</a>)</li> </ul> <h3>3.0.4</h3> <ul> <li>Fixed tar creation error while trying to create tar with path as <code>~/</code> home folder on <code>ubuntu-latest</code>. (<a href="https://github-redirect.dependabot.com/actions/cache/issues/689">issue</a>)</li> </ul> <h3>3.0.5</h3> <ul> <li>Removed error handling by consuming actions/cache 3.0 toolkit, Now cache server error handling will be done by toolkit. (<a href="https://github-redirect.dependabot.com/actions/cache/pull/834">PR</a>)</li> </ul> <h3>3.0.6</h3> <ul> <li>Fixed <a href="https://github-redirect.dependabot.com/actions/cache/issues/809">#809</a> - zstd -d: no such file or directory error</li> <li>Fixed <a href="https://github-redirect.dependabot.com/actions/cache/issues/833">#833</a> - cache doesn't work with github workspace directory</li> </ul> <h3>3.0.7</h3> <ul> <li>Fixed <a href="https://github-redirect.dependabot.com/actions/cache/issues/810">#810</a> - download stuck issue. A new timeout is introduced in the download process to abort the download if it gets stuck and doesn't finish within an hour.</li> </ul> <h3>3.0.8</h3> <ul> <li>Fix zstd not working for windows on gnu tar in issues <a href="https://github-redirect.dependabot.com/actions/cache/issues/888">#888</a> and <a href="https://github-redirect.dependabot.com/actions/cache/issues/891">#891</a>.</li> <li>Allowing users to provide a custom timeout as input for aborting download of a cache segment using an environment variable <code>SEGMENT_DOWNLOAD_TIMEOUT_MIN</code>. Default is 60 minutes.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/cache/commit/fd5de65bc895cf536527842281bea11763fefd77"><code>fd5de65</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/cache/issues/899">#899</a> from actions/kotewar/download-and-compression-fix</li> <li><a href="https://github.com/actions/cache/commit/d49b6bb21d712fc1556f99339b8324b1603f7560"><code>d49b6bb</code></a> Updated actions/cache toolkit dep to v3.0.4</li> <li><a href="https://github.com/actions/cache/commit/a7c34adf76222e77931dedbf4a45b2e4648ced19"><code>a7c34ad</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/cache/issues/894">#894</a> from actions/kotewar/update-toolkit-version</li> <li><a href="https://github.com/actions/cache/commit/83394c99b7089b29ee6c302fad5e940df48c472a"><code>83394c9</code></a> Updated cache version in license file</li> <li><a href="https://github.com/actions/cache/commit/e839c25979e6ffdd90792d34de69d6a87d3016f6"><code>e839c25</code></a> Updated actions/cache version to 3.0.3</li> <li><a href="https://github.com/actions/cache/commit/33a923d660988a68affcd47de6bd6744193223a6"><code>33a923d</code></a> Added release information</li> <li><a href="https://github.com/actions/cache/commit/a404368986bb049d406166fc20afc01d032ad8a2"><code>a404368</code></a> Updated actions/cache version to 3.0.2</li> <li><a href="https://github.com/actions/cache/commit/f4278025ab0f432ce369118909e46deec636f50c"><code>f427802</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/actions/cache/issues/887">#887</a> from actions/pdotl-version-patch</li> <li><a href="https://github.com/actions/cache/commit/9916fe1701f098b95a05e7c2bacee7c5a022c553"><code>9916fe1</code></a> Update cache version in licences</li> <li><a href="https://github.com/actions/cache/commit/318935ef66557a1906560e4e7d0069344a4b31bf"><code>318935e</code></a> Update README and RELEASES</li> <li>Additional commits viewable in <a href="https://github.com/actions/cache/compare/v2...v3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/cache&package-manager=github_actions&previous-version=2&new-version=3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 4041: Fix invalid Haddock markup r=amesgen a=amesgen # Description Fixes invalid Haddock markup introduced in #3817 and #3936. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexander Esgen <[email protected]>

mgmeier requested review from coot, bolt12 and nfrisby as code owners June 20, 2022 13:16

mgmeier added the WIP Do not merge, work in progress. label Jun 20, 2022

mgmeier self-assigned this Jun 20, 2022

mgmeier marked this pull request as draft June 20, 2022 13:18

mgmeier force-pushed the mkarg/db-synthesizer branch from cf3c9e7 to d392739 Compare June 20, 2022 13:22

This was referenced Jun 20, 2022

db-synthesizer: implementation IntersectMBO/cardano-node#3825

Closed

db-analyser: refactor and move IntersectMBO/cardano-node#3974

Closed

mgmeier force-pushed the mkarg/db-synthesizer branch from 5d2819f to 34b5f7a Compare July 7, 2022 07:18

deepfire reviewed Jul 7, 2022

View reviewed changes

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBSynthesizer/Forging.hs Outdated Show resolved Hide resolved

deepfire reviewed Jul 7, 2022

View reviewed changes

ouroboros-consensus/src/Ouroboros/Consensus/NodeKernel.hs Outdated Show resolved Hide resolved

mgmeier changed the title ~~New project ouroboros-consensus-cardano-tools containing db-synthesizer and a refactored db-analyser~~ New project ouroboros-consensus-cardano-tools Jul 13, 2022

dnadales reviewed Jul 29, 2022

View reviewed changes

mgmeier force-pushed the mkarg/db-synthesizer branch from 5b48079 to 4efc9e5 Compare August 3, 2022 11:52

mgmeier removed the WIP Do not merge, work in progress. label Aug 3, 2022

mgmeier marked this pull request as ready for review August 3, 2022 15:13

dnadales reviewed Aug 3, 2022

View reviewed changes

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBAnalyser/Block/Byron.hs Show resolved Hide resolved

dnadales reviewed Aug 3, 2022

View reviewed changes

ouroboros-consensus-cardano-tools/src/Cardano/Tools/DBAnalyser/Block/Cardano.hs Outdated Show resolved Hide resolved

dnadales approved these changes Aug 3, 2022

View reviewed changes

mgmeier requested a review from njd42 as a code owner August 3, 2022 16:29

mgmeier added 6 commits August 8, 2022 15:19

cardano-tools: new project (squashed)

ae73f61

cardano-tools: make DLLs available for test suite

6391cd8

cardano-tools: eliminate merge/rebase noise from PR

54e5b1d

cardano-tools: remove db-analyser from previous location

7639f89

Signed-off-by: Michael Karg <[email protected]>

cardano-tools: (styling) rearrange import groups

40f12bf

cardano-tools: (styling) disappear .. wildcards from project code

a8fbb65

mgmeier added 7 commits August 8, 2022 15:19

cardano-tools: provide command line options and usage in comments

56d049d

cardano-tools: update nix definitions from master

440033b

cardano-tools: condition locally defined

76a43c8

Signed-off-by: Michael Karg <[email protected]>

cardano-tools: styling; more explicit test case

a92ff11

cardano-tools: documentation; test-case fix

5ab9a55

cardano-tools: changelog entry

fad72b5

cardano-tools: minor style fixes

4649635

mgmeier force-pushed the mkarg/db-synthesizer branch from e373911 to 4649635 Compare August 8, 2022 13:21

iohk-bors bot merged commit 548af5b into master Aug 9, 2022

iohk-bors bot deleted the mkarg/db-synthesizer branch August 9, 2022 16:25

amesgen mentioned this pull request Sep 23, 2022

Fix invalid Haddock markup #4041

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New project `ouroboros-consensus-cardano-tools` #3817

New project `ouroboros-consensus-cardano-tools` #3817

mgmeier commented Jun 20, 2022 •

edited

Loading

deepfire Jul 7, 2022

deepfire Jul 7, 2022 •

edited

Loading

mgmeier Jul 8, 2022

dnadales left a comment

mgmeier commented Aug 3, 2022

dnadales left a comment

mgmeier commented Aug 9, 2022

iohk-bors bot commented Aug 9, 2022

New project ouroboros-consensus-cardano-tools #3817

New project ouroboros-consensus-cardano-tools #3817

Conversation

mgmeier commented Jun 20, 2022 • edited Loading

deepfire Jul 7, 2022

Choose a reason for hiding this comment

deepfire Jul 7, 2022 • edited Loading

Choose a reason for hiding this comment

mgmeier Jul 8, 2022

Choose a reason for hiding this comment

dnadales left a comment

Choose a reason for hiding this comment

mgmeier commented Aug 3, 2022

dnadales left a comment

Choose a reason for hiding this comment

mgmeier commented Aug 9, 2022

iohk-bors bot commented Aug 9, 2022

New project `ouroboros-consensus-cardano-tools` #3817

New project `ouroboros-consensus-cardano-tools` #3817

mgmeier commented Jun 20, 2022 •

edited

Loading

deepfire Jul 7, 2022 •

edited

Loading