Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ouroboros-consensus-protocol-test a standalone package inside of a sub-library. #3788

Closed
wants to merge 1 commit into from

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Jun 3, 2022

Sub-libraries are not supported by stack (see commercialhaskell/stack#5318) and provide here very little benefits other than being able to nest files under one directory. Plus, this is inconsistent with how current test libraries (e.g. ouroboros-consensus-shelley-test) are handled.

Feel free to reject this PR and close it saying "we don't want to support stack". I am simply opening to raise awareness about this problem and because I had to fork the repository to do this anyway.

… a sub-library.

  Sub-libraries are not supported by stack and provide here very little benefits other than being able to nest files under one directory. Plus, this is inconsistent with how current test libraries (e.g. ouroboros-consensus-shelley-test) are handlded.
@hasufell
Copy link

hasufell commented Jun 7, 2022

@KtorZ there's a (drunk) PR attempt to fix this in stack, have you tried it?

commercialhaskell/stack#5659

@KtorZ
Copy link
Contributor Author

KtorZ commented Jun 7, 2022

@hasufell yup, saw that! Yet "drunk attempt" kind of drove me away and I feared that it may be more effort to get this working that actually forking the repository and removing the sub-libraries. I was happy to see that Hai did submit a PR and I guess he hit the same wall as I did with Plutus 🤷 ... I did also fork Plutus for the same reasons but removing the sub-libraries was a bit too much effort there.

Perhaps it's better to pick up Hai's PR and get it implemented in stack after all.

@dnadales
Copy link
Member

Thank you @KtorZ 🙌 The change seems sensible. We'll look into the hydra error and review this.

Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems nice to make life easier for Stack users 👍

I think that adding ouroboros-consensus-protocol-test to cabal.project will fix the Hydra error, see 2ced2ba (just cherry-pick/amend).

@coot coot added the consensus issues related to ouroboros-consensus label Oct 25, 2024
@amesgen
Copy link
Member

amesgen commented Oct 25, 2024

Routine cleanup of stale PRs targeting Consensus components (which nowadays live in https://github.com/IntersectMBO/ouroboros-consensus).

No work is lost, see https://stackoverflow.com/a/17954767.

@amesgen amesgen closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants