P2P review of merged PRs #3408
Merged
P2P review of merged PRs #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Oct 5, 2021
coot
commented
- CAD-3444 snocket changes from p2p-master #3369
- CAD-3444 handshake changes from p2p-master #3370
- snocket: move bang patterns to the top of the recursive call
- snocket: fixed some typos
- snocket: remote path for local sockets
- handshake: renamed MsgProposeVersions' as MsgReplyVersions
- handshake: test that acceptOrRefuse is symmetric
- handshake: fixed some typos
- handshake: implement more properties
- handshake: updated documentation
coot
force-pushed
the
coot/snocket-review
branch
2 times, most recently
from
9b71104
to
de9fc93
Compare
For local socket set remote address as `<addr>@<cnt>` where `<addr>` is the local socket path and cnt is an integer. Unfortunately, this require to make `accept` return an `IO` action. For Berkeley sockets we need to get the name of the listening socket.
Apply them to: * acceptable property test * acceptOrRefuse property test They should be used in other tests as well: issue #3406.
coot
force-pushed
the
coot/snocket-review
branch
from
de9fc93
to
c50c998
Compare
bolt12
approved these changes
Oct 6, 2021
coot
force-pushed
the
coot/snocket-review
branch
from
c50c998
to
e4acb05
Compare
dcoutts
reviewed
Oct 7, 2021
dcoutts
reviewed
Oct 7, 2021
* renamed `MsgProposeVersions'` to `MsgReplyVersions` * elaborate on the handshake version negotiation properties * elaborate on non-injective encoding
coot
force-pushed
the
coot/snocket-review
branch
from
e4acb05
to
154a9e7
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.