Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in the thread tracking set #3398

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix race condition in the thread tracking set #3398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ouroboros-network-framework/src/Ouroboros/Network/Server/Socket.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,10 @@ mainLoop errorPolicyTrace resQ threadsVar statusVar complete main =
connectionTx :: STM (IO t)
connectionTx = do
result <- STM.readTQueue resQ
-- Make sure we don't cleanup before spawnOne has inserted the thread
isMember <- Set.member (resultThread result) <$> STM.readTVar threadsVar
STM.check isMember

st <- STM.readTVar statusVar
CompleteApplicationResult
{ carState
Expand Down