Handle exceptions thrown by makeResolvSeed #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1960 . |
dcoutts
reviewed
Apr 16, 2020
ouroboros-network-framework/src/Ouroboros/Network/Subscription/Dns.hs
Outdated
Show resolved
Hide resolved
iohk-bors bot
added a commit
that referenced
this pull request
Apr 17, 2020
1969: Added `catches` to MonadCatch r=dcoutts a=coot Related to #1961 Co-authored-by: Marcin Szamotulski <[email protected]>
makeResolvSeed will fail if /etc/resolv.conf is missing. This can cause DNS subscription to stop working for OSes where that file is generated automatically, for example OSX, during temporary network outages.
|
bors r+ |
coot
added a commit
that referenced
this pull request
May 16, 2022
1969: Added `catches` to MonadCatch r=dcoutts a=coot Related to #1961 Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeResolvSeed will fail if /etc/resolv.conf is missing.
This can cause DNS subscription to stop working for OSes where
that file is generated automatically, for example OSX, during temporary
network outages.