-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop openssl dep #1774
Drop openssl dep #1774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming those fromIntegral
conversions are not needed on any platform then this looks fine.
cabal.project
Outdated
@@ -210,7 +210,7 @@ source-repository-package | |||
source-repository-package | |||
type: git | |||
location: https://github.com/input-output-hk/cardano-crypto/ | |||
tag: 3c707936ba0a665375acf5bd240dc4b6eaa6c0bc | |||
tag: 2547ad1e80aeabca2899951601079408becbc92c | |||
--sha256: 0g8ln8k8wx4csdv92bz09pr7v9dp4lcyv1334b09c9rgwdwhqg1b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip:
nix-prefetch-git https://github.com/input-output-hk/cardano-crypto 2547ad1e80aeabca2899951601079408becbc92c
Initialized empty Git repository in /tmp/git-checkout-tmp-mn30nsyu/cardano-crypto-2547ad1/.git/
remote: Enumerating objects: 104, done.
remote: Counting objects: 100% (104/104), done.
remote: Compressing objects: 100% (92/92), done.
remote: Total 104 (delta 5), reused 68 (delta 2), pack-reused 0
Receiving objects: 100% (104/104), 152.66 KiB | 873.00 KiB/s, done.
Resolving deltas: 100% (5/5), done.
From https://github.com/input-output-hk/cardano-crypto
* branch HEAD -> FETCH_HEAD
Switched to a new branch 'fetchgit'
removing `.git'...
git revision is 2547ad1e80aeabca2899951601079408becbc92c
path is /nix/store/bvxsj0yv59b5k3yzsgbl2082i97lc5z8-cardano-crypto-2547ad1
git human-readable version is -- none --
Commit date is 2020-02-18 09:14:29 +0800
hash is 1p2kg2w02q5w1cvqzhfhqmxviy4xrzada3mmb096j2n6hfr20kri
{
"url": "https://github.com/input-output-hk/cardano-crypto",
"rev": "2547ad1e80aeabca2899951601079408becbc92c",
"date": "2020-02-18T09:14:29+08:00",
"sha256": "1p2kg2w02q5w1cvqzhfhqmxviy4xrzada3mmb096j2n6hfr20kri",
"fetchSubmodules": false
}
So 1p2kg2w02q5w1cvqzhfhqmxviy4xrzada3mmb096j2n6hfr20kri
is the right value here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I should stop abusing ci to give me the correct hash :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR: I actually find it a bit strange that we list a dependency on cardano-crypto
in cabal.project
but not in stack.yaml
😕
Hm it's actually specified in the resolver wrapper: Why do we need this? |
I guess it's an inconsistency in |
bors r+ |
1789: Fix stack for windows r=mrBliss a=kderme Related #1082 Continuation of #1774, which makes use of IntersectMBO/cardano-prelude#100 Co-authored-by: kderme <[email protected]>
1789: Fix stack for windows r=mrBliss a=kderme Related #1082 Continuation of #1774, which makes use of IntersectMBO/cardano-prelude#100 Co-authored-by: kderme <[email protected]>
1789: Fix stack for windows r=mrBliss a=kderme Related #1082 Continuation of #1774, which makes use of IntersectMBO/cardano-prelude#100 Co-authored-by: kderme <[email protected]>
With this pr, ouroboros-consensus no longer needs openssl to build. This significantly simplifies building on windows. Related #1082
WIP: TODO nix