network: add IsIdle argument to the PeerFetchStatusReady fingerprint #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1147.
I've been using this commit during all of my recent development on the tests -- without it, Issue #1147 failures have occasionally masked my other focus.
I still don't have a repro on master, but I think I'll be able to find one after a couple more PRs are merged -- the #1147 failure has arisen during my development even without the simulated network latency that originally revealed it.
Disclaimer: though this commit seems well-vetted by the use in the not-yet-on-
mastertests mentioned above, I do not understand theBlockFetchcode very well, and moreover it's been a while since I actually wrote this code (in particular, I'm not exactly sure what it is that the Boolean adds beyond checking if the adjacent set is empty). It'd be wonderful to see a localized test case for this.