Simplify the en/decoder for PBFtChainState #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/fix-1609
branch
from
1839e41 to
197c4f0
Compare
mrBliss
commented
Feb 11, 2020
ouroboros-consensus/src/Ouroboros/Consensus/Protocol/PBFT/ChainState.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/Protocol/PBFT/ChainState.hs
Outdated
Show resolved
Hide resolved
mrBliss
force-pushed
the
mrBliss/fix-1609
branch
2 times, most recently
from
006ba5a to
1b06eb1
Compare
Fixes #1609. Since we're breaking backwards compatibility of the `ExtLedgerState` serialisation format, we can get rid of the code dealing with backwards compatibility in `PBFtChainState`. Nevertheless, start using `Versioned` for `PBFtChainState` so that it will be easier in the future to handle changes to the format.
mrBliss
force-pushed
the
mrBliss/fix-1609
branch
from
1b06eb1 to
d1cac31
Compare
edsko
approved these changes
Feb 11, 2020
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 11, 2020
1618: Simplify the en/decoder for PBFtChainState r=mrBliss a=mrBliss Fixes #1609. Since we're breaking backwards compatibility of the `ExtLedgerState` serialisation format, we can get rid of the code dealing with backwards compatibility in `PBFtChainState`. Nevertheless, start using `Versioned` for `PBFtChainState` so that it will be easier in the future to handle changes to the format. Co-authored-by: Thomas Winant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609.
Since we're breaking backwards compatibility of the
ExtLedgerStateserialisation format, we can get rid of the code dealing with backwards compatibility inPBFtChainState.Nevertheless, start using
VersionedforPBFtChainStateso that it will be easier in the future to handle changes to the format.