Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test clock changes #1601

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Test clock changes #1601

merged 1 commit into from
Feb 10, 2020

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Feb 7, 2020

This adds tests for #1554 as a separate PR, because tests tests depend on #1539 .

@mrBliss mrBliss self-requested a review February 7, 2020 08:15
@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Feb 7, 2020
mrBliss
mrBliss approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@mrBliss mrBliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already reviewed this when it was part of #1554.

This was referenced Feb 7, 2020
Merged
Merged
@edsko edsko force-pushed the edsko/test-clock-changes branch from e3353cf to e55cc6a Compare February 7, 2020 14:57
@edsko
Copy link
Contributor Author

edsko commented Feb 7, 2020

Reduced the footprint of this PR. This now depends on #1604 and #1539 (which in turn depends also on 1604).

iohk-bors bot added a commit that referenced this pull request Feb 7, 2020
@iohk-bors @edsko
Merge #1604
d4302c8 
1604: Minor cleanup r=edsko a=edsko

This is mostly extracted from #1601 , in an attempt to make that as small as possible.

Co-authored-by: Edsko de Vries <[email protected]>
@edsko edsko force-pushed the edsko/test-clock-changes branch from e55cc6a to 3df3a73 Compare February 7, 2020 15:19
@edsko
Copy link
Contributor Author

edsko commented Feb 7, 2020

Blocked on #1539 .

@edsko edsko force-pushed the edsko/test-clock-changes branch from 3df3a73 to 73ee4f8 Compare February 10, 2020 08:50
@edsko
Copy link
Contributor Author

edsko commented Feb 10, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Feb 10, 2020
@iohk-bors @edsko
Merge #1601
8e7e591 
1601: Test clock changes r=edsko a=edsko

This adds tests for #1554 as a separate PR, because tests tests depend on #1539 .

Co-authored-by: Edsko de Vries <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 10, 2020

Build succeeded

@iohk-bors iohk-bors bot merged commit 73ee4f8 into master Feb 10, 2020
@iohk-bors iohk-bors bot deleted the edsko/test-clock-changes branch February 10, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrBliss mrBliss mrBliss approved these changes

Assignees
No one assigned
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edsko @mrBliss