Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise ouroboros-network modules #1519

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Jan 28, 2020

  • add ouroboros-protocol-tests library. It includes all the Example
    and Test modules which were under Ouroboros.Network.Protocols, with
    one exception: Ouroboros.Network.Protocols.ChainSync.Example which is
    required for test-conesnsus. We might be able to fix this in future
    by makeing ouroboros-protocol-test library public.
  • test-network library depends on the internal
    ouroboros-protocol-tests library.

* add `ouroboros-protocol-tests` library. It includes all the Example
  and Test modules which were under `Ouroboros.Network.Protocols`, with
  one exception: `Ouroboros.Network.Protocols.ChainSync.Example` which is
  required for `test-conesnsus`.  We might be able to fix this in future
  by makeing ouroboros-protocol-test library public.
* `test-network` library depends on the internal
  `ouroboros-protocol-tests` library.
@coot coot requested review from dcoutts and karknu January 28, 2020 18:45
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just update the cddl tests too.

It is also renamed to `test-cddl`.
@coot
Copy link
Contributor Author

coot commented Jan 28, 2020

One step towards #1411

@coot coot added this to the S5 2020-01-30 milestone Jan 28, 2020
@coot
Copy link
Contributor Author

coot commented Jan 28, 2020

bors r+

iohk-bors bot added a commit that referenced this pull request Jan 28, 2020
1519: Reorganise ouroboros-network modules r=coot a=coot

* add `ouroboros-protocol-tests` library. It includes all the Example
  and Test modules which were under `Ouroboros.Network.Protocols`, with
  one exception: `Ouroboros.Network.Protocols.ChainSync.Example` which is
  required for `test-conesnsus`.  We might be able to fix this in future
  by makeing ouroboros-protocol-test library public.
* `test-network` library depends on the internal
  `ouroboros-protocol-tests` library.

Co-authored-by: Marcin Szamotulski <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 28, 2020

@iohk-bors iohk-bors bot merged commit ceee1e5 into master Jan 28, 2020
@iohk-bors iohk-bors bot deleted the coot/cabal-components branch January 28, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants