Generalize StrictT(M)Var invariant #1040
Merged
+47
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than just returning a `Bool`, we return `Maybe` an error message. This paves the way for more detailed information we get back from the NF check.
edsko
force-pushed
the
edsko/generalize-tvar-invariant
branch
from
5d58ef7 to
6dc6745
Compare
|
Ok, this works. Ready for review and to be merged. |
mrBliss
approved these changes
Sep 19, 2019
| @@ -18,6 +18,11 @@ source-repository head | |||
| location: https://github.com/input-output-hk/ouroboros-network | |||
| subdir: io-sim-classes | |||
|
|
|||
| flag checktvarinvariant | |||
There was a problem hiding this comment.
When/where do we enable this flag?
Thinking out loud: we want to enable it always (?) for test-consensus and test-storage. We don't want to have to pass it manually via the cmd line.
| Dealing with invariants | ||
| -------------------------------------------------------------------------------} | ||
|
|
||
| checkInvariant :: HasCallStack => Maybe String -> m x -> m x |
There was a problem hiding this comment.
Would it be useful to reuse this function to check other invariants than this one? I mean instead of assert, which does not support a custom error message (or a call stack with a depth > 1).
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 20, 2019
1040: Generalize StrictT(M)Var invariant r=edsko a=edsko Rather than just returning a `Bool`, we return `Maybe` an error message. This paves the way for more detailed information we get back from the NF check. Marking this as a draft because still untested. Co-authored-by: Edsko de Vries <[email protected]>
|
It's a good suggestion regarding enabling the flag on CI, but I don't know how to do it. Opened a separate ticket for it IntersectMBO/ouroboros-consensus#756 . |
coot
pushed a commit
that referenced
this pull request
May 16, 2022
1040: Generalize StrictT(M)Var invariant r=edsko a=edsko Rather than just returning a `Bool`, we return `Maybe` an error message. This paves the way for more detailed information we get back from the NF check. Marking this as a draft because still untested. Co-authored-by: Edsko de Vries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just returning a
Bool, we returnMaybean error message. This paves the way for more detailed information we get back from the NF check.Marking this as a draft because still untested.