Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid reading the header in ChainDB #1594

Closed
edsko opened this issue Feb 6, 2020 · 0 comments · Fixed by #1597
Closed

Avoid reading the header in ChainDB #1594

edsko opened this issue Feb 6, 2020 · 0 comments · Fixed by #1597
Labels
chain db consensus issues related to ouroboros-consensus enhancement New feature or request
Milestone
S6 2020-02-13

Comments

@edsko
Copy link
Contributor

edsko commented Feb 6, 2020

See #1589 (comment) , #1589 (comment) , #1589 (comment) .
@edsko edsko mentioned this issue Feb 6, 2020
Merged
@edsko edsko added chain db consensus issues related to ouroboros-consensus enhancement New feature or request priority low labels Feb 6, 2020
@mrBliss mrBliss added this to the S6 2020-02-13 milestone Feb 6, 2020
mrBliss added a commit that referenced this issue Feb 6, 2020
@mrBliss
ChainDB: don't read the header at the ImmutableDB's tip on startup
5338278 
Fixes #1594.
@mrBliss mrBliss mentioned this issue Feb 6, 2020
Merged
iohk-bors bot added a commit that referenced this issue Feb 7, 2020
@iohk-bors @mrBliss
Merge #1597
9139f1f 
1597: Follow-up on #1589 r=mrBliss a=mrBliss

Fixes #1594 and #1595.

* ChainSyncClient: use WithOrigin BlockNo for MkPipelineDecision

* ChainDB: don't read the header at the ImmutableDB's tip on startup


Co-authored-by: Thomas Winant <[email protected]>
@iohk-bors iohk-bors bot closed this as completed in 624b60a Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chain db consensus issues related to ouroboros-consensus enhancement New feature or request
Projects
None yet
Milestone
S6 2020-02-13
Development

Successfully merging a pull request may close this issue.

Follow-up on #1589 IntersectMBO/ouroboros-network
2 participants
@mrBliss @edsko