Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2125): fix counting governance action expiration #2138

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(#2125): fix counting governance action expiration #2138

merged 1 commit into from
Oct 11, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • fix counting governance action expiration

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Oct 10, 2024 that may be closed by this pull request
[USERSNAP] dates are wrong. epoch boundary, and therefore expiry is Sunday 6th October. #2125
Closed
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/2125-usersnap-dates-are-wrong-epoch-boundary-and-therefore-expiry-is-sunday-6th-october branch from 3e77b81 to 3a5d163 Compare October 10, 2024 12:41
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 56d4ea5 into develop Oct 11, 2024
10 checks passed
@MSzalowski MSzalowski deleted the fix/2125-usersnap-dates-are-wrong-epoch-boundary-and-therefore-expiry-is-sunday-6th-october branch October 11, 2024 08:00
@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-56d4ea53fcce8c58eff44c9020280fa1bf9ef382 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-56d4ea53fcce8c58eff44c9020280fa1bf9ef382 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-56d4ea53fcce8c58eff44c9020280fa1bf9ef382 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[USERSNAP] dates are wrong. epoch boundary, and therefore expiry is Sunday 6th October.
2 participants
@MSzalowski @placek