fix(#1989): workaround for downloading metadata on iOS Safari #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All checks succeeded |
2 similar comments
|
✅ All checks succeeded |
|
✅ All checks succeeded |
MSzalowski
force-pushed
the
fix/1989--mobile-cant-download-metadata
branch
from
22b65dd
to
d783f68
Compare
MSzalowski
force-pushed
the
fix/1989--mobile-cant-download-metadata
branch
from
d783f68
to
85be603
Compare
|
✅ All checks succeeded |
5 similar comments
|
✅ All checks succeeded |
|
✅ All checks succeeded |
|
✅ All checks succeeded |
|
✅ All checks succeeded |
|
✅ All checks succeeded |
jdyczka
approved these changes
Oct 1, 2024
|
@MSzalowski |
|
@MSzalowski |
|
@MSzalowski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Reason for the workaround is the limitation on iOS.
Safari browser on iOS blocks programmatically generated file downloads for security reasons.
Because of that, if the interaction is triggered on mobile safari, I made that open a new tab with the json content - allowing user to manually download this data and meet the security requirements on iOS.
Checklist