Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1856 missing off chain data #2093

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Fix/1856 missing off chain data #2093

merged 2 commits into from
Oct 2, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Sep 30, 2024

List of changes

  • Add @language property to jsonld
  • Fix parsing nested metadata (for references)
  • Add info about off chain data error from dbSync

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka requested a review from Ryun1 as a code owner September 30, 2024 09:01
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@jdyczka jdyczka merged commit 5b7b695 into develop Oct 2, 2024
8 checks passed
@jdyczka jdyczka deleted the fix/1856-missing-off-chain-data branch October 2, 2024 07:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

@jdyczka
This PR is in the tag: develop-5b7b695430f1483975ee4794f12f2ee1b121bec7 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

@jdyczka
This PR is in the tag: develop-5b7b695430f1483975ee4794f12f2ee1b121bec7 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

@jdyczka
This PR is in the tag: develop-5b7b695430f1483975ee4794f12f2ee1b121bec7 , for govtool-backend service

@jdyczka jdyczka mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdyczka @MSzalowski @j-dyczka