Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2059] Improve poor UTxO management #2063

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

Ryun1
Copy link
Member

@Ryun1 Ryun1 commented Sep 19, 2024

List of changes

  • Removed explicit UTxO output which caused poor selection

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Ryun1
Copy link
Member Author

Ryun1 commented Sep 19, 2024

This also requires #2061
Otherwise there will be issues creating valid transactions for DRep retirements

Copy link

✅ All checks succeeded

2 similar comments
Copy link

✅ All checks succeeded

Copy link

✅ All checks succeeded

@Ryun1
Copy link
Member Author

Ryun1 commented Sep 19, 2024

ahh wait, this breaks DRep registration...
let me fix

@Ryun1
Copy link
Member Author

Ryun1 commented Sep 19, 2024

There is an edge case where a user has a UTxO with 501 ada and they try to register as a DRep
And this 501 UTxO gets (randomly) selected to be used in the transaction
The transaction will just balance itself to have that one input, resulting in a fee paid of 1 ada (and no outputs created)

@Ryun1 Ryun1 merged commit ecdfd24 into develop Sep 19, 2024
3 checks passed
@Ryun1 Ryun1 deleted the 2059-fix-poor-utxo-management branch September 19, 2024 13:31
@Ryun1 Ryun1 changed the title [2059] Fix poor UTxO management [2059] Improve poor UTxO management Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants