Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Tests/Hardfork Conditions, and Update Tests for Recent Changes #1966

Merged
merged 21 commits into from
Sep 9, 2024

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Sep 6, 2024

List of changes

  • Add Test 5L to restrict votes to Info governance actions during bootstrap.
  • Add a temporary registerDRep wallet for Test 3Q.
  • Add Test 3Q to ensure that a dRep is excluded from the dRep directory when 'doNotList' is checked.
  • Add Test 6T to display the correct network name.
  • Add Test 6S to warn users about the bootstrapping phase during bootstrapping.
  • Skip all govtool tests if the protocol version is less than 9.
  • Use multiple stake ADA holders for delegated ADA visibility testing.
  • Fix dRep registration-dependent tests due to the addition of links and identity reference fields.
  • Update package-lock.json with the latest package versions.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add test to warn user that they are in bootstrapping phase and some feature are disabled
@kneerose kneerose force-pushed the feat/test-conditions-hardfork branch from 7300844 to 2fc441b Compare September 9, 2024 07:48
Copy link

github-actions bot commented Sep 9, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Sep 9, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 9, 2024

✅ All checks succeeded

@kneerose kneerose merged commit c7b24c6 into develop Sep 9, 2024
10 checks passed
@kneerose kneerose deleted the feat/test-conditions-hardfork branch September 9, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants