Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1894): make response of the metadata restricted to be raw text #1920

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Sep 3, 2024

List of changes

  • Make response of the metadata restricted to be raw text.
  • Enforce format of the stringified metadata to match the resulting content on the pre-validation step.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Sep 3, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1894-drep-metdata-validation branch from 4e3bb67 to d8e7699 Compare September 3, 2024 16:33
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1894-drep-metdata-validation branch from a3f5f0f to 3b53f3d Compare September 3, 2024 17:24
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

1 similar comment
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

@MSzalowski MSzalowski merged commit d240a87 into develop Sep 3, 2024
9 checks passed
@MSzalowski MSzalowski deleted the fix/1894-drep-metdata-validation branch September 3, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 DRep metdata validation
2 participants