Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/(#1850) final designs for CIP-119 #1904

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Sep 2, 2024

List of changes

  • Change displaying DRep details to match final designs
  • Change displaying DRep registration form to match final designs
  • Change displaying edit DRep metadata form to match final designs
  • Add suport for Link and Identity reference types, as well as reference label, for DRep references
  • Change references type returned from metadata validation service to include type and label
  • Add support for Do Not List

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka marked this pull request as draft September 2, 2024 12:59
Copy link

github-actions bot commented Sep 2, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Sep 2, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 2, 2024

✅ All checks succeeded

@jdyczka jdyczka force-pushed the feat/1850-final-designs-for-cip119 branch from e1a4930 to 2c6b110 Compare September 2, 2024 13:21
Copy link

github-actions bot commented Sep 2, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 2, 2024

❌ Docker Image Scan (Dockle) failed

No output

Copy link

github-actions bot commented Sep 2, 2024

✅ All checks succeeded

@jdyczka jdyczka force-pushed the feat/1850-final-designs-for-cip119 branch 2 times, most recently from 88a99db to 7d60434 Compare September 2, 2024 14:55
@jdyczka jdyczka marked this pull request as ready for review September 2, 2024 14:56
Copy link

github-actions bot commented Sep 2, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 2, 2024

❌ Docker Image Scan (Dockle) failed

No output

Copy link

github-actions bot commented Sep 2, 2024

✅ All checks succeeded

@MSzalowski
Copy link
Contributor

Approved, but please fix checks

@jdyczka jdyczka force-pushed the feat/1850-final-designs-for-cip119 branch from 7d60434 to 0116a36 Compare September 3, 2024 10:08
@jdyczka jdyczka force-pushed the feat/1850-final-designs-for-cip119 branch from 0116a36 to 5b11033 Compare September 3, 2024 10:08
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

2 similar comments
Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

Copy link

github-actions bot commented Sep 3, 2024

✅ All checks succeeded

@jdyczka jdyczka merged commit d1e7e39 into develop Sep 3, 2024
8 checks passed
@jdyczka jdyczka deleted the feat/1850-final-designs-for-cip119 branch September 3, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants