Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1601): get rid of junk data in protocol parameter change Gov Action #1868

Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix(#1601): get rid of junk data in protocol parameter change Gov Action #1868

merged 3 commits into from
Aug 29, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • get rid of junk data in protocol parameter change Gov Action

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Aug 29, 2024 that may be closed by this pull request
Rendering Protocol Parameter Change Governance Actions #1601
Closed
@MSzalowski MSzalowski force-pushed the fix/1601-junk-data-in-protocol-parameter-change-governance-actions branch from b47d1b4 to 7daff02 Compare August 29, 2024 13:53
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

3 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1601-junk-data-in-protocol-parameter-change-governance-actions branch from 7daff02 to ecf486a Compare August 29, 2024 14:08
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 51e039d into develop Aug 29, 2024
8 checks passed
@MSzalowski MSzalowski deleted the fix/1601-junk-data-in-protocol-parameter-change-governance-actions branch August 29, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryun1 Ryun1 Ryun1 left review comments

@jdyczka jdyczka jdyczka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rendering Protocol Parameter Change Governance Actions
3 participants
@MSzalowski @jdyczka @Ryun1