Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1838): fix counting CC and SPO votes #1857

Merged

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Aug 28, 2024

List of changes

  • fix counting CC and SPO votes

Screenshot for the updated gov action from the issue:
Zrzut ekranu z 2024-08-28 17-20-12

@Ryun1 Does it look legit now? 🤔

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link

✅ All checks succeeded

2 similar comments
Copy link

✅ All checks succeeded

Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/1838-constitutional-committee-votes-not-counted branch from 8d30eb5 to c243413 Compare August 29, 2024 06:18
Copy link

✅ All checks succeeded

2 similar comments
Copy link

✅ All checks succeeded

Copy link

✅ All checks succeeded

Comment on lines +20 to +26
const Vote = ({
vote,
value,
}: {
vote: "yes" | "no" | "abstain";
value: string | number;
}) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ryun1 Does it look legit now? 🤔

Looks great!

@MSzalowski MSzalowski merged commit 51eaa97 into develop Aug 29, 2024
10 checks passed
@MSzalowski MSzalowski deleted the fix/1838-constitutional-committee-votes-not-counted branch August 29, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Constitutional Committee Votes not counted
3 participants