Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to tar images #1821

Merged
merged 4 commits into from
Aug 28, 2024
Merged

switch to tar images #1821

merged 4 commits into from
Aug 28, 2024

Conversation

Baja-KS
Copy link
Contributor

@Baja-KS Baja-KS commented Aug 26, 2024

List of changes

  • Add / Fix / Change / Remove

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Baja-KS Baja-KS marked this pull request as ready for review August 26, 2024 12:28
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@mpavlovicbb mpavlovicbb requested review from MSzalowski and removed request for placek and adgud August 26, 2024 13:10
MSzalowski
MSzalowski reviewed Aug 26, 2024
View reviewed changes
.github/workflows/merge.yaml Outdated
--container ${{ matrix.qovery_container_name }} \
--tag ${{ env.TAG }} \
--watch
# - name: Deploy with Qovery
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just get rid of those lines? We still can revert them anytime

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@mpavlovicbb mpavlovicbb merged commit 5f9ea52 into develop Aug 28, 2024
3 checks passed
@mpavlovicbb mpavlovicbb deleted the ci-scan-fix branch August 28, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski left review comments

@mpavlovicbb mpavlovicbb mpavlovicbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Baja-KS @MSzalowski @mpavlovicbb