Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor auth setup #1607

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Refactor auth setup #1607

merged 1 commit into from
Jul 24, 2024

Conversation

kneerose
Copy link
Contributor

List of changes

  • Extract out duplicate auth setup into a helper function and use them on auth

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip July 24, 2024 07:33
mesudip
mesudip approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kneerose kneerose merged commit 1a86aa9 into develop Jul 24, 2024
1 check passed
@kneerose kneerose deleted the refactor/auth-setup branch July 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip