Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1582): Add support for CIP-100 on vote metadata #1603

Merged
merged 2 commits into from
Jul 29, 2024
Merged

fix(#1582): Add support for CIP-100 on vote metadata #1603

merged 2 commits into from
Jul 29, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • Add support for CIP-100 on vote metadata

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jul 23, 2024 that may be closed by this pull request
Vote metadata following the CIP-100 standard #1582
Closed
@MSzalowski MSzalowski requested review from jdyczka and removed request for Sworzen1 and JanJaroszczak July 23, 2024 12:41
@MSzalowski MSzalowski marked this pull request as draft July 24, 2024 09:23
@MSzalowski MSzalowski force-pushed the fix/1582-vote-metadata-following-the-cip-100-standard branch 2 times, most recently from f57b263 to acc3ee1 Compare July 29, 2024 11:50
@MSzalowski MSzalowski marked this pull request as ready for review July 29, 2024 12:02
@MSzalowski MSzalowski force-pushed the fix/1582-vote-metadata-following-the-cip-100-standard branch 2 times, most recently from c140d15 to a9b0a17 Compare July 29, 2024 14:33
@MSzalowski MSzalowski force-pushed the fix/1582-vote-metadata-following-the-cip-100-standard branch from a9b0a17 to f880076 Compare July 29, 2024 14:40
Ryun1
Ryun1 reviewed Jul 29, 2024
View reviewed changes
govtool/frontend/src/hooks/forms/useVoteContextForm.tsx Outdated
});
const jsonld = await generateJsonld(body, CIP_100_CONTEXT, CIP_100);

const canonizedJson = await canonizeJSON(jsonld);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The need for canonising was removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get rid of all the canonized jsons then (GA and DRep metadatas)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for all metadata

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologise, this must have slipped through the cracks in our communications

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not problem at all 🫡

@MSzalowski MSzalowski requested a review from Ryun1 July 29, 2024 15:41
@MSzalowski
Copy link
Contributor Author

@Ryun1 I've removed usage of canonization within this commit: 08e8a57
Could you please re-verify this pr? 💪

@MSzalowski MSzalowski force-pushed the fix/1582-vote-metadata-following-the-cip-100-standard branch from 08e8a57 to 6d0fac5 Compare July 29, 2024 15:48
Ryun1
Ryun1 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please re-verify this pr? 💪

LGTM!

@MSzalowski MSzalowski merged commit 8174a9f into develop Jul 29, 2024
5 checks passed
@MSzalowski MSzalowski deleted the fix/1582-vote-metadata-following-the-cip-100-standard branch July 29, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdyczka jdyczka jdyczka approved these changes

@Ryun1 Ryun1 Ryun1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vote metadata following the CIP-100 standard
3 participants
@MSzalowski @jdyczka @Ryun1