Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: proposal draft test blocked by verify identity button #1548

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix: proposal draft test blocked by verify identity button #1548

merged 2 commits into from
Jul 10, 2024

Conversation

kneerose
Copy link
Contributor

List of changes

  • Fix test 7C, 7L, 7M, 7N

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from NabinKawan July 10, 2024 08:49
NabinKawan
NabinKawan approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kneerose kneerose merged commit f3954ac into develop Jul 10, 2024
1 check passed
@kneerose kneerose deleted the bugfix/test-proposal-draft branch July 10, 2024 08:57
@pmbinapps pmbinapps mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NabinKawan NabinKawan NabinKawan approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @NabinKawan