Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1501] Set proposal discussion forum enabled by default #1533

Merged
merged 2 commits into from
Jul 19, 2024
Merged

[#1501] Set proposal discussion forum enabled by default #1533

merged 2 commits into from
Jul 19, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Jul 9, 2024 •
edited
Loading

List of changes

  • Change default value for setting proposal discussion forum to enabled on every environment

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka self-assigned this Jul 9, 2024
MSzalowski
MSzalowski requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change default value also in frontend Dockerfile

@jdyczka jdyczka force-pushed the 1501-default-enable-proposal-discussion-forum branch from 7c3df21 to acf70df Compare July 16, 2024 14:36
@MSzalowski MSzalowski self-requested a review July 18, 2024 11:06
@MSzalowski MSzalowski force-pushed the 1501-default-enable-proposal-discussion-forum branch from acf70df to 3eb1a5f Compare July 18, 2024 11:08
@MSzalowski MSzalowski requested a review from Ryun1 as a code owner July 18, 2024 11:08
@jdyczka jdyczka force-pushed the 1501-default-enable-proposal-discussion-forum branch from 3eb1a5f to 95761c8 Compare July 19, 2024 13:05
@jdyczka jdyczka merged commit 9011cba into develop Jul 19, 2024
7 checks passed
@jdyczka jdyczka deleted the 1501-default-enable-proposal-discussion-forum branch July 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@MSzalowski MSzalowski MSzalowski approved these changes

@adgud adgud Awaiting requested review from adgud adgud is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees

@jdyczka jdyczka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdyczka @placek @MSzalowski @j-dyczka