Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/proposal submission #1507

Merged
merged 27 commits into from
Jul 10, 2024
Merged

Refactor/proposal submission #1507

merged 27 commits into from
Jul 10, 2024

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Jul 6, 2024

List of changes

  • Change the proposal submission test according to the new flow
  • Added new tests for proposal draft to cover new workflow
  • 7C: Should list unfinished draft
  • 7L: Should save proposal as a draft
  • 7M: Should edit proposal draft
  • 7N: Should submit a draft proposal

Note: This PR is only intended to merge after pdf-ui version (0.2.4) is deployed to test

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from NabinKawan July 6, 2024 04:12
@kneerose
chore: Update proposal creation request type and its form validation
c260ee7
@kneerose
chore: Update Test 7C flow to show unfinished draft list per latest u…
00ebc29 
…ser stories
@kneerose
fix: test 7D according to new flow
eacecd9
@kneerose
chore: Update the fill-up form flow and the generated valid field fak…
642b696 
…er value.
@kneerose
Fix: Update test 7E Accept valid proposal form according to the new…
c27177a 
… proposal creation flow
@kneerose
Fix: Update test 7F Reject invalid proposal form according to the n…
9c91cc4 
…ew proposal creation flow
@kneerose
chore: Update generate valid and invalid proposal form field props type
4a9f91e
@kneerose
chore: Refactor test 7G flow to create a proposal with proper data
15b9fe7
@kneerose
chore: Update test 7I review fillup form flow
1fe3e0a
@kneerose
chore: Update metadata anchor validation test
a3292c0 
Change metadata anchor validatation test from 7K to 7J and update its flow according to userstories
@kneerose
chore: Update reject invalid metadata test
41eee95 
Change metadata anchor validatation test from 7L to 7K and update its flow according to userstories
@kneerose
chore: Migrate 7J and 7K test from proposal submission functionality …
67f12cc 
…to proposal submission loggedin
@kneerose
feat: Add Tests 7L, 7M, and 7N Related to Proposal Draft
71bb185
@kneerose
chore: Rename proposal.setup.ts file to governance-action.setup.ts
333d694
@kneerose
chore: Update project proposals on playwright config
200d6be
@kneerose
chore: Update test 7H to submit a proposal as a governance action acc…
87c8306 
…ording to the new flow.
@kneerose
chore: Remove duplicate proposal create request and fix proposal link…
e9397d4 
… type
@kneerose
chore: Remove unused functions and change the reward address on the p…
6cf54c1 
…roposal submission page
@kneerose
chore: Add missing elements in proposal Discussing page
559a4ae
@kneerose
chore: Handle the 'Create Proposal' or 'continue' button on the propo…
30b0986 
…sal creation page, regardless of whether a draft is available
@kneerose
chore: Migrate proposalSubmissionVisibility.loggedin test to proposal…
121e487 
…Submission.loggedin
@kneerose
chore: Update create proposal logic
636fc16
@kneerose
chore: Refactor proposal auth and proposal fixture
bd4b895
@kneerose
chore: Update proposal discussion navigation url and add amount input…
9a23dd8 
… test id
@kneerose
fix: Test 7J and 7K
d785ebd 
Fix test 7J by updating invalid url test id and test 7k by updating the url
@kneerose
chore: Add temporary proposal users for draft test
2f7cc12
@kneerose kneerose force-pushed the refactor/proposal-submission branch from e3290d6 to ea05e08 Compare July 10, 2024 05:57
NabinKawan
NabinKawan approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kneerose kneerose merged commit f1202aa into develop Jul 10, 2024
5 checks passed
@kneerose kneerose deleted the refactor/proposal-submission branch July 10, 2024 07:02
@pmbinapps pmbinapps mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NabinKawan NabinKawan NabinKawan approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @NabinKawan