Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended/pdf tests #1480

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Extended/pdf tests #1480

merged 2 commits into from
Jul 9, 2024

Conversation

NabinKawan
Copy link
Contributor

@NabinKawan NabinKawan commented Jul 5, 2024 •
edited
Loading

List of changes

  • Added new tests for pdf-ui to cover new new workflow
  • 8U: Should disable anonymous comment
  • 6K: Should accept valid username
  • 6L: Should reject invalid username

Note: This PR is only intended to merge after pdf-ui version (0.2.4) is deployed to test

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@NabinKawan NabinKawan requested a review from kneerose July 5, 2024 09:38
kneerose
kneerose approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@kneerose kneerose left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict. otherwise, LGTM

@NabinKawan NabinKawan merged commit 060cbbe into develop Jul 9, 2024
5 checks passed
@NabinKawan NabinKawan deleted the extended/pdf-tests branch July 9, 2024 10:37
This was referenced Jul 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneerose kneerose kneerose approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NabinKawan @kneerose