Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test 1E: Incompatible wallets #1459

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Fix test 1E: Incompatible wallets #1459

merged 2 commits into from
Jul 3, 2024

Conversation

NabinKawan
Copy link
Contributor

@NabinKawan NabinKawan commented Jul 3, 2024 •
edited
Loading

List of changes

  • Updated version of cardano-test-wallet to 2.0.0
  • Updated wallet (fixtures, helper) to support cardano-test-wallet version 2.0.0
  • Fixed test for incompatible wallets

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@NabinKawan NabinKawan requested a review from mesudip July 3, 2024 07:30
mesudip
mesudip approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@NabinKawan NabinKawan merged commit 48d871c into develop Jul 3, 2024
1 check passed
@NabinKawan NabinKawan deleted the bugfix/test-icompatible-wallets branch July 3, 2024 09:49
This was referenced Jul 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NabinKawan @mesudip