Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/metadata validation #1395

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Fix/metadata validation #1395

merged 3 commits into from
Jun 21, 2024

Conversation

NabinKawan
Copy link
Contributor

@NabinKawan NabinKawan commented Jun 21, 2024 •
edited
Loading

List of changes

  • Added test-ids for metadata-anchor-error
  • Updated assertion for metadata validation
  • Fixed test 3H (Should update dRep data)

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@NabinKawan NabinKawan requested a review from mesudip June 21, 2024 08:46
@NabinKawan NabinKawan merged commit 8ff03fa into develop Jun 21, 2024
@NabinKawan NabinKawan deleted the fix/metadata-validation branch June 21, 2024 09:15
@pmbinapps pmbinapps mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NabinKawan @mesudip @kneerose