Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/sonarqube analysis #1338

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Fix/sonarqube analysis #1338

merged 5 commits into from
Jun 19, 2024

Conversation

mesudip
Copy link
Contributor

@mesudip mesudip commented Jun 19, 2024

List of changes

  • Use npmrc token when running test before SonarQube analysis.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@mesudip mesudip requested a review from NabinKawan June 19, 2024 09:26
NabinKawan
NabinKawan approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mesudip mesudip self-assigned this Jun 19, 2024
@mesudip mesudip merged commit 0b41db6 into develop Jun 19, 2024
1 check failed
@mesudip mesudip deleted the fix/sonarqube-analysis branch June 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NabinKawan NabinKawan NabinKawan approved these changes

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud adgud is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees

@mesudip mesudip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesudip @NabinKawan