Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/1257-dashboard-shows-delegation-in-two-places-should-be-one-after-becoming-a-drep #1262

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix/1257-dashboard-shows-delegation-in-two-places-should-be-one-after-becoming-a-drep #1262

merged 2 commits into from
Jun 12, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Jun 12, 2024 •
edited
Loading

List of changes

  • Hide delegation for delegation on myself

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 linked an issue Jun 12, 2024 that may be closed by this pull request
Dashboard shows delegation in two places, should be one, after becoming a DRep #1257
Closed
@MSzalowski
Copy link
Contributor

Check the failing test please

@Sworzen1
Copy link
Contributor Author

done

@Sworzen1 Sworzen1 merged commit bb489f2 into develop Jun 12, 2024
3 of 4 checks passed
@Sworzen1 Sworzen1 deleted the fix/1257-dashboard-shows-delegation-in-two-places-should-be-one-after-becoming-a-drep branch June 12, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard shows delegation in two places, should be one, after becoming a DRep
2 participants
@Sworzen1 @MSzalowski